Repository navigation
fix(comparison): validate project existence and reject unknown ids with 404 (#930) - #939
Closed
mopxam-art wants to merge 1 commit into
Closed
mopxam-art wants to merge 1 commit into
mopxam-art wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Endpoints
/v1/comparison,/v1/comparison/ranking,/v1/comparison/export, and/v1/dashboard/timeseries/:idsynthesized simulated metrics for arbitrary and nonexistent project IDs without validating existence against the on-chain registry. This allowed consumers to receive fabricated portfolio data and probe arbitrary IDs.What
projectExistsinsrc/lib/comparison.ts(loadProjectMetrics,compareProjects,generateRanking) andsrc/routes/dashboard.ts(/timeseries/:id).not_found(Project <id> not found).MAX_U32_PROJECT_IDso valid contractu32ranges are delegated to registry existence checks rather than throwing arbitrary400errors.not_foundbehavior inAPI.mdfor/v1/dashboard/timeseries/:id,/v1/comparison,/v1/comparison/ranking, and CSV exports.src/__tests__/comparison-existence-validation.test.ts). All tests pass.Verified
jest src/__tests__/comparison-existence-validation.test.ts, 125 tests pass).tsc --noEmit) passes with 0 errors.tsc) succeeds cleanly.Closes #930
USDC (EVM / Arbitrum / ERC20): 0x387c064ccf729a4846b62e95dc6b70e4d4c41e73