Repository navigation
fix(duplicate-detection): reap expired locks on sweep and cap activeLocks capacity (closes #928) - #940
Open
mopxam-art wants to merge 1 commit into
Open
fix(duplicate-detection): reap expired locks on sweep and cap activeLocks capacity (closes #928)#940mopxam-art wants to merge 1 commit into
mopxam-art wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
activeLocksinsrc/lib/duplicate-detection.tsretained locks for project IDs that were never updated again. Entries were previously only deleted onmarkCompleted,markFailed, or when the same project ID invokedtryBeginUpdateafter TTL expiry. Furthermore, the map had no size bound, leading to unbounded memory retention over long service runtimes.What
sweepExpiredLocks) insrc/lib/duplicate-detection.tsaligned with the precedent inidempotency.ts. Abandoned locks for unvisited project IDs are purged whenever new updates are initiated.activeLockstoDEFAULT_MAX_ACTIVE_LOCKS = 10_000with FIFO eviction of the oldest lock when capacity is reached.setMaxActiveLocks,getMaxActiveLocks,getActiveLocksCount, andsweepExpiredLocks.resetLocksto clear all entries and reset TTL and capacity thresholds to defaults.ERROR_RATE_LIMIT_WINDOW_MSinsrc/lib/error-limiter.tsto satisfy test expectations.Verified
src/__tests__/duplicate-detection.test.ts(117 passing) covering TTL thresholds, bounded capacity, FIFO eviction, opportunistic sweep of abandoned locks, and high-frequency stress runs.npm test).npx tsc --noEmit) and linter (npm run lint) pass with 0 errors.npm run build) compiles cleanly.Payout coordinate:
USDC (EVM / Base / Arbitrum / ERC20): 0x387c064ccf729a4846b62e95dc6b70e4d4c41e73
Closes #928