Repository navigation
fix(security): enforce scoped content security policy on docs route - #941
Open
mopxam-art wants to merge 1 commit into
Open
mopxam-art wants to merge 1 commit into
mopxam-art wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Content-Security-Policy was entirely disabled for all routes matching
/docsto allow Swagger UI initialization scripts to run. While other security headers remained active, disabling CSP completely left the documentation surface without origin and object containment.What
DEFAULT_CSP_DIRECTIVESand scopedDOCS_CSP_DIRECTIVESinsrc/middleware/securityHeaders.ts.https://unpkg.com,https://validator.swagger.io) specifically on/docswhile strictly maintainingobject-src 'none',frame-ancestors 'none',base-uri 'self', andform-action 'self'./docsand/docs/subpaths, ensuring raw API routes like/docs.jsonretain default strict CSP without inline script permissions.res.removeHeader("Content-Security-Policy")hook fromsrc/index.ts.Verified
src/__tests__/securityHeaders.test.ts(102 passing) asserting CSP header presence, directive structure across routes, HTTP methods, and rapid sequential requests.npx tsc --noEmit) and linter pass with 0 errors.npm run build) succeeded.Closes #924
Payout coordinate:
USDC (EVM / Base / Arbitrum / ERC20): 0x387c064ccf729a4846b62e95dc6b70e4d4c41e73