Repository navigation
fix(multichain): reject EVM chain submissions with explicit error and eliminate fabricated transaction hashes - #945
Open
mopxam-art wants to merge 1 commit into
Conversation
… eliminate fabricated transaction hashes (closes Heliobond#921)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
src/lib/multichain.tssynthesized artificial hexadecimal strings and formatted them as transaction hashes (0x${chain.id}_${projectId}_...and0x${Buffer.from(...)}) for EVM chains (Ethereum and Polygon). These fake hashes were presented as successful cross-chain submissions in API responses and internal broadcast results, even though no EVM contract call was executed.What
submitToChain(src/lib/multichain.ts).EVM chain submission not configured for ...: missing rpcUrl or contractAddress) when configuration is absent, and not-implemented error (EVM chain submission is not implemented for ...) when configured, leavingtxHashempty ("") andsuccess: false.src/__tests__/multichain.test.tsto verify that no fabricated hash is ever emitted.Verified
src/__tests__/multichain-no-fake-hashes.test.ts(105 passing, 149 across multichain suites) proving zero synthetic hashes are emitted across all project IDs, score boundaries, and target configurations.npm test).npx tsc --noEmit) and linter pass with 0 errors.npm run build) succeeded.Closes #921
Payout coordinate:
USDC (EVM / Base / Arbitrum / ERC20): 0x387c064ccf729a4846b62e95dc6b70e4d4c41e73