Repository navigation
test: retain bounded default-root-build watcher failure diagnostics - #451
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MISSING.Bounds and limits
512 tail events, at most 2 KiB per event, fixed first/last phase anchors, 256 visited fixture entries, 16 MiB combined snapshots, and 18 MiB total including metadata. The ring's ordered tail is materialized only for failure serialization. Success persists no diagnostic artifact.
Capture errors cannot replace the original test or cleanup outcome. Existing consumer assertions, search predicate, 20-second wait, test deadlines, selection, concurrency, callback arguments/promises, and error propagation are unchanged. No retries, sleeps, warmup, production telemetry, watcher fix, or loader shim.
Symlink, hardlink, special-file, and replaced-root refusal remain fail-closed. Stop/close success is a quiescence prerequisite, not proof of database consistency. POSIX mode/directory-FD guards may refuse Windows snapshots as
MISSING; Windows snapshot coverage is unverified. Filtering, queueing, flushing, native notifications, and replacement-emitter coverage are explicitly unavailable rather than inferred.Native provenance is ordinary-cache observation only; any digest means current disk, not previously executed bytes. Raw fixture index files can embed temporary paths; artifacts must not be committed or published unreviewed.
Verification
Latest refinement, each natural command run once on the frozen reviewed source:
npm run build && npm run typecheck && npm run lint && npm run test:run: 143 files passed, 1 skipped; 2,826 tests passed, 6 skipped.8864f8a9f99fb2e4bc9df789a62018cc09f354c8: both Linux Node 22/24 full jobs and all six OS path-semantics jobs succeeded. All four CodeQL Analyze jobs succeeded; the separate aggregate CodeQL check was neutral, not a failed analyzer. Label and drafter checks succeeded.Synthetic index/statistics examples are not a real database, Indexer measurement, or watcher-failure reproduction. No natural failure was deliberately induced or observed. Failure-artifact upload was skipped in both passing CI full-test jobs; actual upload-on-failure and Windows snapshot retention are not exercised. The six OS path-semantics jobs do not establish cross-platform artifact-helper coverage.
Review state
Parent source, local-evidence, exact five-file scope, and current-CI review accepted for this PR only. Passing runs are non-reproduction only: the historical watcher failure remains FAILED / root cause UNKNOWN, not fixed by this diagnostic PR. No failure waiver is applied here.
Independent of #450, which remains draft and on a separate HOLD with no accepted-risk exception. Feature base:
f8261391ba95ecbd166a224379765f6f76d9f1f6; reviewed head:8864f8a9f99fb2e4bc9df789a62018cc09f354c8, with ordinary followup parentae52cf95a81f533a918d3c756641fc3c04682403.