fix: container create body carries HostConfig and NetworkingConfig - #2
Merged
Merged
Conversation
The Engine API takes ContainerConfig together with HostConfig and NetworkingConfig in one create body; the spec had only ContainerConfig, so callers passed host settings around the types. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Engine API the
/containers/createbody isallOf: [ContainerConfig, {HostConfig, NetworkingConfig}]. The spec had onlyContainerConfig, so host settings (binds, network, limits) had no type and went around it.ContainerCreatenow takesContainerCreateRequest, which isContainerConfigplus optionalHostConfigandNetworkingConfig.The SDK side is Hexlet/docker-ruby#23 (
host_config:oncontainers.create).🤖 Generated with Claude Code