feat: describe image build, pull and push responses as progress streams - #3
Merged
Merged
Conversation
The three operations returned void, so the progress messages the Engine API streams back, including the error that ends a failed build, had no type. They now return HttpStream of BuildInfo, CreateImageInfo and PushImageInfo, whose aux carries what each daemon sends: an image id, a BuildKit trace or the pushed digest. TypeSpec moves to 1.16 for @typespec/streams. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageBuild,ImageCreateandImagePushreturnedvoid, so the progress messages the Engine API streams back had no type. That includes theerrorDetailline that ends a failed build with status 200. The official swagger documents onlyno errorfor these responses; the messages are itsBuildInfo,CreateImageInfoandPushImageInfodefinitions.HttpStream<…, "application/json">from@typespec/http/streams.BuildInfo.aux:ImageID | string. The classic builder sends the image id; BuildKit sends a base64 protobufStatusResponsewhenidismoby.buildkit.trace.PushImageInfo.aux:{Tag, Digest, Size}.errorandprogressare#deprecated; the daemon still sends them.@typespec/streamsis added.The SDK side is Hexlet/docker-ruby#25.
🤖 Generated with Claude Code