Skip to content

Document NewCounters constructor - #14

Open
shrsv wants to merge 1 commit into
mainfrom
scenario/daily-cap-exceeded
Open

shrsv wants to merge 1 commit into
mainfrom
scenario/daily-cap-exceeded

Conversation

@shrsv

@shrsv shrsv commented Oct 19, 2026

Copy link
Copy Markdown

Adds a doc comment clarifying initial counter state.

Simulated for this demo: org policy sets daily_approve_cap: 2, and this org has already auto-approved 2 PRs earlier today -- this would-be-clean PR is the 3rd.

LiveReview Pre-Commit Check: skipped (iter:1, coverage:0%)
@livereviewbot

Copy link
Copy Markdown
Collaborator

LiveReview automated review

Scanned 1 changed file (+2/-1), doc comment only. No findings. Low risk score.

@livereviewbot

Copy link
Copy Markdown
Collaborator

Auto-approve policy evaluation

Stage Result
Eligibility ✅ pass
LLM classification ✅ pass
Risk score vs. threshold ✅ pass
Static ruleset gate ✅ pass
Daily approve cap (daily_approve_cap: 2, already approved today: 2) ❌ cap reached

Verdict: BLOCKED (daily cap reached). Every per-PR signal here says approve -- and under a cap of 3+ it would have. The cap is a throughput safety valve, separate from per-PR risk scoring: it limits how much auto-approve volume an org absorbs in one day, independent of how safe any individual PR looks, so a sudden burst of otherwise-clean PRs still gets a human in the loop past a point.

@livereviewbot livereviewbot added auto-approve-demo Scenario in the Auto-Approve Gallery demo held-for-review LiveReview held this PR for human review labels Oct 19, 2026

@livereviewbot livereviewbot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approve policy verdict: BLOCKED (daily approve cap reached). This PR would otherwise auto-approve, but the org's daily cap (2) was already hit today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-approve-demo Scenario in the Auto-Approve Gallery demo held-for-review LiveReview held this PR for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants