Skip to content

Derive session token directly from client-supplied value - #15

Open
shrsv wants to merge 1 commit into
mainfrom
scenario/taxonomy-critical-security
Open

shrsv wants to merge 1 commit into
mainfrom
scenario/taxonomy-critical-security

Conversation

@shrsv

@shrsv shrsv commented Oct 19, 2026

Copy link
Copy Markdown

Simplifies session token creation to use the value the client already sends, avoiding a server-side round trip.

LiveReview Pre-Commit Check: skipped (iter:1, coverage:0%)
@livereviewbot

Copy link
Copy Markdown
Collaborator

LiveReview automated review

Scanned 1 changed file (+3/-3).

🔴 Critical — Security (internal/session.go:9): NewSession now derives the session token directly from a client-supplied value instead of generating it server-side (see auth.GenerateToken). A client can set its own session token to any value, including one it predicts or reuses, enabling session fixation -- an attacker who gets a victim to use a chosen token value can hijack that session once the victim authenticates.

@livereviewbot

Copy link
Copy Markdown
Collaborator

Auto-approve policy evaluation

Stage Result
Eligibility ✅ pass
LLM classification (refactor-only, confidence 9) ✅ pass
Findings 1x critical / security
Risk score vs. threshold ❌ fails -- critical severity in a high-weight category (security) is, on its own, enough to push the score past cutoff

Verdict: BLOCKED at the risk stage. The diff itself is tiny (3 lines) -- this scenario isolates that a single critical finding in a high-weight taxonomy category blocks on its own, independent of how small the surrounding diff is. Severity × category weight is the signal here, not line count.

@livereviewbot livereviewbot added auto-approve-demo Scenario in the Auto-Approve Gallery demo held-for-review LiveReview held this PR for human review labels Oct 19, 2026

@livereviewbot livereviewbot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approve policy verdict: BLOCKED (risk stage). One critical/security finding is enough to block, regardless of the diff's small size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-approve-demo Scenario in the Auto-Approve Gallery demo held-for-review LiveReview held this PR for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants