Skip to content

Refactor ConnectorStore definition - #138

Open
lovestaco wants to merge 1 commit into
masterfrom
lovestaco-patch-1
Open

lovestaco wants to merge 1 commit into
masterfrom
lovestaco-patch-1

Conversation

@lovestaco

@lovestaco lovestaco commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Describe what changed and why.

Linked Issue

Link the agreed issue this PR fulfills.

Validation

Describe the most specific test or validation you ran.

Checklist

  • This PR fulfills an agreed issue.
  • I kept the change narrow and scoped.
  • I ran the most specific relevant validation and described it above.
  • If I changed behavior, I called that out clearly in this PR.
  • If I touched UI, I attached a GIF or video walkthrough. This is required.
  • If this change touches security, disclosure flow, credentials, storage, network behavior, or licensing/entitlement enforcement, I reviewed SECURITY.md and updated related documentation if needed.
  • I have read and accept the Contributor License Agreement.

Notes For Reviewers

Anything specific you want reviewers to focus on.


🔍 LiveReview

Auto-approval decisions

Review Decision Reason
#13207 ❌ Not approved Risk score 1.00 is above the cutoff of 0.50

⚙️ Customize risk-based approval policy for this repository or your organization.

@livereview-agent-local

Copy link
Copy Markdown

Fix Broken ConnectorStore Type Definition

Overview

This change removes the ConnectorStore struct and its db field. It adds an invalid Connecto type with no underlying type. NewConnectorStore still returns *ConnectorStore, so the package cannot compile.

Technical Highlights

  • storage/aiconnectors/connector_store.go: Removes ConnectorStore struct and db *sql.DB field.
  • storage/aiconnectors/connector_store.go: Adds invalid type Connecto declaration with no underlying type.
  • storage/aiconnectors/connector_store.go: Leaves NewConnectorStore returning *ConnectorStore, causing compile failure.

Impact

  • Functionality: AI connector persistence and DisplayOrderUpdate cannot function.
  • Risk: Package build fails; all ConnectorStore references break.

DisplayOrder int
}

type ConnectorStore struct {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: critical

type Connecto is incomplete and replaces the ConnectorStore struct. NewConnectorStore still returns *ConnectorStore, causing a compile failure. Restore the struct definition or rename all references consistently.

Suggestions:

  1. Restore type ConnectorStore struct { db *sql.DB }.
  2. If renaming to Connecto, add the missing underlying type and update NewConnectorStore and all callers.

@livereview-agent-local livereview-agent-local Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ LiveReview policy: Not approved (blocked at Risk score) · Review #13207

Stage Result Detail
Eligibility ✅ author level 1 >= required 1
Static rules ✅ no blocking rulesets configured
Risk score ❌ Risk score 1.00 is above the cutoff of 0.50
LLM classification ✅ class "logic-change", confidence 9
Final decision ❌ risk: Risk score 1.00 is above the cutoff of 0.50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant