chore(deps): bump encoding_rs from 0.8.35 to 0.8.41 - #6104
Open
dependabot[bot] wants to merge 1 commit into
Open
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
Contributor
|
Thanks @dependabot[bot] for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Bumps [encoding_rs](https://github.com/hsivonen/encoding_rs) from 0.8.35 to 0.8.41. - [Commits](hsivonen/encoding_rs@v0.8.35...v0.8.41) --- updated-dependencies: - dependency-name: encoding_rs dependency-version: 0.8.40 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/cargo/encoding_rs-0.8.40
branch
from
September 12, 2026 18:36
3ec38fd to
c810bc0
Compare
Hmbown
reviewed
Sep 12, 2026
Hmbown
left a comment
Hmbown
left a comment
Owner
There was a problem hiding this comment.
Holding merge at c810bc0: the refreshed Ubuntu job is red in codewhale-cli::telemetry_kill_switch_dispatch::missing_preference_defaults_on_without_inventing_acceptance. It failed at crates/cli/tests/telemetry_kill_switch_dispatch.rs:180 because the expected default-on dry-run receipt was absent. macOS, Windows, lint and dependency security checks passed.
Failure evidence: https://github.com/Hmbown/Codewhale/actions/runs/34711707513/job/103601573540
This identifies the failed gate; it does not establish that encoding_rs caused it. Please retain the failure and diagnose the missing receipt before rerunning. The update also introduces CPU-dispatch/proc-macro dependencies, so a green lockfile/security check alone is not the complete runtime proof.
This was referenced Sep 16, 2026
Hmbown
added a commit
that referenced
this pull request
Sep 16, 2026
…Ubuntu (#6270) `codewhale-cli::telemetry_kill_switch_dispatch::missing_preference_defaults_on_without_inventing_acceptance` has failed twice on Ubuntu CI at `telemetry_kill_switch_dispatch.rs:180` ("default-on writes dry run") on changes that touch neither telemetry nor the CLI: PR #6104 (`c810bc0458`, 2026-09-12) and PR #6267 (`75e032b61d`, 2026-09-16). Both times macOS and Windows passed. It is not an env race. CI runs cargo-nextest, which gives every test its own process, and the test never mutates process-global state — each case spawns the real binary with `env_clear()` and a fresh `TempDir` HOME/CODEWHALE_HOME (`telemetry_kill_switch_dispatch.rs:231-276`). The panic is a *missing file*: `$CODEWHALE_HOME/telemetry/dryrun.jsonl` was never written. The mechanism is a wall-clock deadline. `features list` resolves to `Surface::Cli`, whose exit path waits `CLI_PERSIST_TIMEOUT` — 250 ms (`crates/telemetry/src/lib.rs:75`) — for a detached writer thread that must re-run `decision::re_decide` against disk and then fsync an append before the process exits. The code deliberately fails open, so a missed deadline silently produces no receipt. All three existing test-group overrides filter `binary(integration)`, and this is a *different* binary, so none of them ever matched it: the five cases ran at full parallelism beside 15,774 tests. The CI log shows the runner was saturated at that moment — neighbouring subprocess-spawning tests took 3.5-3.6 s for work that normally finishes well under a second, while this one failed in 0.747 s. This adds the missing override, putting the binary in the existing `telemetry-contract` group (max-threads = 1) for the same reason that group exists: these tests spawn the real binary and cannot absorb scheduler latency. Verified on this machine (macOS aarch64): cargo nextest show-config test-groups -p codewhale-cli --all-features \ --locked -E 'binary(telemetry_kill_switch_dispatch)' group: telemetry-contract (max threads = 1) * override for default profile with filter 'binary(telemetry_kill_switch_dispatch)': codewhale-cli::telemetry_kill_switch_dispatch: (all 5 tests) group: spawns-binaries (max threads = 3) (no matches) sh scripts/with-hermetic-test-home.sh cargo nextest run -p codewhale-cli \ --all-features --locked -E 'binary(telemetry_kill_switch_dispatch)' Summary [0.621s] 5 tests run: 5 passed, 0 skipped Not fixed here: the 250 ms budget itself. Bounding the group removes the load that makes the deadline reachable, but a slow enough host can still miss it. The product-side options — raise CLI_PERSIST_TIMEOUT, hoist the `re_decide` disk read out of the deadline window, or have the CLI path join the writer for the local non-network case — are a behavioural decision, not a test fix, and are left for the issue. Signed-off-by: CodeWhale Bot <bot@codewhale.net> Co-authored-by: CodeWhale Bot <bot@codewhale.net> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps encoding_rs from 0.8.35 to 0.8.41.
Commits
0860491Increment version number to 0.8.412e9ea61Document multiversion 0.9.0 and syn version6667988build(deps): accept multiversion 0.9.0662cb42Allow split_u16_stride_mut as dead code55f2530Increment version number to 0.8.4071ae1c0Mention defense in depth when writing to &mut str12790abRemove remarks about a standard library bug that has been worked aroundd477c2aInline asm not stable on powerpc/powerpc64 at MSRV6c2fb49Work around slow _mm_packus_epi16 in Rust 1.96 through 1.98, inclusive9451175Zero the output slice upon panic in functions that write to &mut str