Repository navigation
build: rebuild committed build outputs only at release - #112
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
hsd review round 1 Verdict: approve. This covers what #111 asks for:
Checks:
Non-blocking nit: LoadSpec no longer touches the |
Collaborator
Author
|
hsd: ready for human review after 1 review round(s). Agent sessions are still live in |
cesutherland
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #111
Summary
spec/LoadSpec.jsnow loadsjs/imagediff.jsinstead of the builtimagediff.js.bin/imagediffrequires../js/imagediff.js, so the CLI and its smoke tests (spec/CliSpec.js) run the current source.imagediff.js/imagediff.min.jsonly when preparing a release. The README's Scripts list points there and notes thatnpm testneeds no build.npm testpasses in the dev container (44 Node specs, browser specs).Decisions
js/ships in the npm package (checked withnpm pack --dry-run), so installed CLIs behave the same. I chose this over redirecting module resolution only inside the test, which would be more fragile.🤖 Generated with Claude Code