Skip to content

fix(ci): re-enable Windows e2e tests - #48

Draft
Hweinstock wants to merge 1 commit into
refactorfrom
fix/windows-e2e-secrets
Draft

Hweinstock wants to merge 1 commit into
refactorfrom
fix/windows-e2e-secrets

Conversation

@Hweinstock

Copy link
Copy Markdown
Owner

Description

Related Issue

No issue was provided; the implementation spec is included below.

Documentation PR

Not applicable. This changes CI and its e2e harness only.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran bun test (3,559 passed in 86.04s)
  • I ran the relevant end-to-end tests with bun run test:e2e, or explained why they are not applicable
    • The AWS-backed Windows e2e path requires the repository's OIDC secret-reader role and CodeBuild runner, so it cannot be reproduced locally. The workflow is validated structurally and will exercise that path in CI.
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • If I modified src/assets/, I updated affected snapshots with bun test <test-file> --update-snapshots and committed them
    • Not applicable; src/assets/ was not modified.

Additional verification:

  • Parsed .github/workflows/e2e-test.yml with the repository's yaml dependency.
  • Asserted both fetch-secrets steps use merge commit 75989f65f7f193deaf83c237c36572d1a8f800b2.
  • Asserted the matrix contains the Windows runner labels image:windows-1.0 and e2e-windows.
  • Collected the e2e suite with AGENTCORE_CLI_PATH=true bunx vitest list --config vitest.e2e.config.ts.
  • Ran bunx vitest run e2eTest/helpers/run.test.ts; the regression test verifies that CliRunner.stop() terminates shell-spawned descendants that ignore SIGTERM.
  • git diff --check

Reproduction

  1. On the refactor base, inspect .github/workflows/e2e-test.yml.
  2. Observe that the Windows matrix entry is commented out and both secret-fetch steps use the older action revision.
  3. Check out this branch and inspect the same workflow.
  4. Observe that Windows is an active matrix entry and both secret-fetch steps use the merged Windows-compatible revision.
  5. Run or dispatch the reusable e2e workflow with repository secrets configured; the e2e job now includes Linux, Windows, and macOS. On Windows, the Linux-container template is omitted from project dev, its exact project manifest is restored before deployment, and its managed lifecycle checks still run.

Spec

Problem: CI on the CLI refactor branch does not run e2e tests on Windows because the fetch-secrets workflow was not Windows-compatible.

Definition of done:

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
    • Structural workflow assertions and the cross-platform e2e harness changes cover the configuration change.
  • I have updated the documentation accordingly
    • Not applicable; no customer documentation changes.
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant