fix(ci): re-enable Windows e2e tests - #48
Draft
Hweinstock wants to merge 1 commit into
Draft
Hweinstock wants to merge 1 commit into
Hweinstock wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fetch-secretssteps to the merged Windows-compatible action from fix(fetch-secrets): swap fetch secret action to use node instead of bash aws/agentcore-devx-devtools#5.project devprocess tree during e2e cleanup on Windows and POSIX.Related Issue
No issue was provided; the implementation spec is included below.
Documentation PR
Not applicable. This changes CI and its e2e harness only.
Type of Change
Testing
How have you tested the change?
bun test(3,559 passed in 86.04s)bun run test:e2e, or explained why they are not applicablebun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themsrc/assets/was not modified.Additional verification:
.github/workflows/e2e-test.ymlwith the repository'syamldependency.fetch-secretssteps use merge commit75989f65f7f193deaf83c237c36572d1a8f800b2.image:windows-1.0ande2e-windows.AGENTCORE_CLI_PATH=true bunx vitest list --config vitest.e2e.config.ts.bunx vitest run e2eTest/helpers/run.test.ts; the regression test verifies thatCliRunner.stop()terminates shell-spawned descendants that ignoreSIGTERM.git diff --checkReproduction
refactorbase, inspect.github/workflows/e2e-test.yml.project dev, its exact project manifest is restored before deployment, and its managed lifecycle checks still run.Spec
Problem: CI on the CLI refactor branch does not run e2e tests on Windows because the fetch-secrets workflow was not Windows-compatible.
Definition of done:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.