refactor(project): lift project commands to the top level - #49
Closed
Hweinstock wants to merge 12 commits into
Closed
Hweinstock wants to merge 12 commits into
Hweinstock wants to merge 12 commits into
Conversation
Hweinstock
marked this pull request as draft
September 23, 2026 22:18
Hweinstock
commented
Sep 23, 2026
| // projectSubcommands reads the project group's children off the compiled | ||
| // Commander tree, so tests driven by it cover any subcommand added later. | ||
| function projectSubcommands(): string[] { | ||
| // topLevelSubcommands reads the root's children off the compiled Commander |
Owner
Author
There was a problem hiding this comment.
i actually think we should be able to remove this whole test file, it should be duplicating existing tests that already hit the top level. Lets verify removing this doesnt drop coverage, and drop it.
|
|
||
| ## Table of contents | ||
|
|
||
| - [Global options](#global-options) |
Owner
Author
There was a problem hiding this comment.
avoid changing this file, its generated on release, so just remove it. Also after making this change, find a link tot he comment from TJ on a recent PR of hweinstock that said not to touch this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentcore project ...to top-level commandsValidation
bun test— 3,558 passed, 0 failedbun run typecheckbun run lint:checkbun run format:checkbun run secrets:checkReview notes
Two implementation bugs were fixed in dedicated commits: deploy was advertised but not registered, and the initial config/middleware/TUI wiring refactor dropped existing behavior. A final test-only follow-up corrected stale generic root-menu expectations. No new tests were added.