Repository navigation
Add Rust adapters for core node components - #10
Open
tj (tjkilgore93-stack) with Copilot wants to merge 2 commits into
Open
tj (tjkilgore93-stack) with Copilot wants to merge 2 commits into
tj (tjkilgore93-stack) with Copilot wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: tjkilgore93-stack <313495784+tjkilgore93-stack@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add Rust wrappers and update CI tooling for Rust validation
Add Rust adapters for core node components
Oct 13, 2026
tj (tjkilgore93-stack)
marked this pull request as ready for review
October 13, 2026 07:26
There was a problem hiding this comment.
🟡 Changes recommended
JavaScript validation is removed from CI, and the Rust transform API mislabels quaternion data as rotation.
3 open findings
What changed in this PR
Adds a Rust workspace with typed adapters for the 23 core node kinds and Rust-focused CI validation.
Changes:
- Adds shared Rust node wrappers, transforms, registry, and tests.
- Adds Cargo workspace metadata and Rust CI checks.
- Removes Deno configuration/CI and ignores Rust build output.
| File | Description |
|---|---|
rust/components/src/lib.rs |
Defines component adapters and tests. |
rust/components/Cargo.toml |
Configures the components crate. |
Cargo.toml |
Defines the Cargo workspace. |
Cargo.lock |
Locks workspace packages. |
.github/workflows/rust.yml |
Adds Rust CI validation. |
.github/workflows/deno.yml |
Removes Deno CI. |
deno.json |
Removes Deno lint configuration. |
.gitignore |
Ignores Cargo build output. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+26
to
+27
| - name: Run tests | ||
| run: cargo test --workspace |
Comment on lines
+10
to
+23
| pub struct NodeTransform { | ||
| pub position: [f64; 3], | ||
| pub rotation: [f64; 4], | ||
| pub scale: [f64; 3], | ||
| } | ||
|
|
||
| impl Default for NodeTransform { | ||
| fn default() -> Self { | ||
| Self { | ||
| position: [0.0; 3], | ||
| rotation: [0.0, 0.0, 0.0, 1.0], | ||
| scale: [1.0; 3], | ||
| } | ||
| } |
Comment on lines
+107
to
+110
| fn registry_matches_all_core_node_component_kinds() { | ||
| assert_eq!( | ||
| COMPONENT_KINDS, | ||
| &[ |
tjkilgore93-stack
approved these changes
Oct 13, 2026
tj (tjkilgore93-stack)
marked this pull request as draft
October 13, 2026 16:21
tj (tjkilgore93-stack)
marked this pull request as ready for review
October 13, 2026 16:21
tjkilgore93-stack
approved these changes
Oct 14, 2026
tj (tjkilgore93-stack)
marked this pull request as draft
October 15, 2026 22:38
tjkilgore93-stack
approved these changes
Oct 15, 2026
tjkilgore93-stack
approved these changes
Oct 15, 2026
tj (tjkilgore93-stack)
marked this pull request as ready for review
October 15, 2026 22:39
tjkilgore93-stack
approved these changes
Oct 15, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Introduce a Rust-first validation path and pure Rust adapters for the project’s core node component kinds, without restoring Deno CI.