Skip to content

Replace Deno CI with pure Rust validation workflow - #9

Open
tj (tjkilgore93-stack) with Copilot wants to merge 2 commits into
mainfrom
copilot/update-rust-workflow
Open

tj (tjkilgore93-stack) with Copilot wants to merge 2 commits into
mainfrom
copilot/update-rust-workflow

Conversation

Copilot AI commented Oct 13, 2026 •

Copy link
Copy Markdown

The legacy Deno CI workflow was removed to stop irrelevant lint and test failures across the repository. This change introduces a minimal, standard GitHub Actions workflow dedicated purely to validating Rust tooling.

Workflow Changes

  • Remove Deno workflow: Deleted .github/workflows/deno.yml.
  • Add Rust CI workflow: Added .github/workflows/rust.yml configured to:
    • Trigger on push and pull_request against main.
    • Enforce least-privilege token permissions (contents: read).
    • Provision the stable Rust toolchain and rustfmt component via dtolnay/rust-toolchain.
    • Execute cargo fmt --all --check, cargo check --verbose, and cargo test --verbose.

Workflow Definition

name: Rust

on:
  push:
    branches: ["main"]
  pull_request:
    branches: ["main"]

permissions:
  contents: read

env:
  CARGO_TERM_COLOR: always

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout repository
        uses: actions/checkout@v4

      - name: Install stable Rust toolchain
        uses: dtolnay/rust-toolchain@stable
        with:
          toolchain: stable
          components: rustfmt

      - name: Check formatting
        run: cargo fmt --all --check

      - name: Run cargo check
        run: cargo check --verbose

      - name: Run cargo test
        run: cargo test --verbose

@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperfy Error Error Oct 13, 2026 4:59am UTC

Co-authored-by: tjkilgore93-stack <313495784+tjkilgore93-stack@users.noreply.github.com>
Copilot AI changed the title [WIP] Add pure Rust CI workflow to replace Deno workflow Replace Deno CI with pure Rust validation workflow Oct 13, 2026
@tjkilgore93-stack
tj (tjkilgore93-stack) marked this pull request as ready for review October 14, 2026 10:33
Copilot AI balanced review requested due to automatic review settings October 14, 2026 10:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Rust workflow will fail because the repository contains no Cargo manifest or Rust crate.

1 open finding
What changed in this PR

Replaces the Deno workflow with Rust-focused CI validation.

Changes:

  • Removes Deno linting and testing.
  • Adds Rust formatting, compilation, and test checks.
File Description
.github/​workflows/​rust.yml Adds Rust CI validation.
.github/​workflows/​deno.yml Removes legacy Deno CI.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +31 to +35
- name: Check formatting
run: cargo fmt --all --check

- name: Run cargo check
run: cargo check --verbose

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

Comment on lines +31 to +32
- name: Check formatting
run: cargo fmt --all --check

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Validation fails without a Cargo project

Every run fails at cargo fmt --all --check because the repository has no Cargo manifest. Neither cargo check nor cargo test runs.

Learn more

The workflow runs at the repository root after checkout. This repository contains package.json and JavaScript source, but no Cargo.toml or Rust source. Cargo needs a manifest before it can format, check, or test a project, so every run stops at the first Cargo command.

Example: A pull request changes src/core/billing.js. Checkout succeeds, then cargo fmt --all --check reports that no Cargo.toml exists; the job fails without validating the change.

Recommended fix: Replace the Cargo steps with checks for the actual Node project, using the Node version specified by package.json and installing dependencies before running its checks. If Rust validation is intended for a future project, introduce its manifest and sources first.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread .github/workflows/rust.yml Resolved

This branch had an error being deployed

1 failed deployment
Preview — a308ef38 Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants