Repository navigation
Fix Deno test workflow failure from WinDbg entrypoint false positives - #1
Conversation
Co-authored-by: tjkilgore93-stack <313495784+tjkilgore93-stack@users.noreply.github.com>
test workflow failure from WinDbg entrypoint false positives
Co-authored-by: tjkilgore93-stack <313495784+tjkilgore93-stack@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.Unrecognized words (1)denoland These words are not needed and should be removedADDREFTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:tjkilgore93-stack/terminal.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/cfb6f7e75bbfc89c71eaa30366d0c166f1bd9c8c/apply.pl' |
perl - 'https://github.com/tjkilgore93-stack/terminal/actions/runs/35179600818/attempts/2' &&
git commit -m 'Update check-spelling metadata'OR To have the bot accept them for you, comment in the PR quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (2028) from .github/actions/spelling/expect/alphabet.txt .github/actions/spelling/expect/expect.txt .github/actions/spelling/expect/web.txt and unrecognized words (1)
Consider adding to the "cspell:cpp/src/lang-keywords.txt",
"cspell:csharp/csharp.txt",
"cspell:cpp/src/compiler-clang-attributes.txt",
"cspell:aws/aws.txt",
"cspell:python/src/python/python.txt",
To stop checking additional dictionaries, put (in the "check_extra_dictionaries": []Pattern suggestions ✂️ (1)You could add these patterns to Alternatively, if a pattern suggestion doesn't make sense for this project, add a Notices ℹ️ (1)See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.
See ℹ️ Event descriptions for more information. ✏️ Contributor please read thisBy default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later. If the listed items are:
See the 🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉 If the flagged items are 🤯 false positivesIf items relate to a ...
|
The GitHub Actions
testjob was failing duringdeno lintbecause WinDbg script entrypoints intools/WindbgExtension.jsare invoked externally and were flagged as unused. This change scopes the fix to those entrypoints only.Root cause
deno lintreportedno-unused-varsforinitializeScriptandServiceLocatorVarintools/WindbgExtension.js.Change
deno-lint-ignore no-unused-varsdirectives directly above both externally-invoked function declarations.Illustrative diff