Skip to content

Fix Deno test workflow failure from WinDbg entrypoint false positives - #1

Merged
tj (tjkilgore93-stack) merged 3 commits into
mainfrom
copilot/fix-failing-github-actions-job-test
Sep 17, 2026
Merged

tj (tjkilgore93-stack) merged 3 commits into
mainfrom
copilot/fix-failing-github-actions-job-test

Conversation

Copilot AI commented Sep 17, 2026 •

Copy link
Copy Markdown

The GitHub Actions test job was failing during deno lint because WinDbg script entrypoints in tools/WindbgExtension.js are invoked externally and were flagged as unused. This change scopes the fix to those entrypoints only.

  • Root cause

    • deno lint reported no-unused-vars for initializeScript and ServiceLocatorVar in tools/WindbgExtension.js.
  • Change

    • Added targeted deno-lint-ignore no-unused-vars directives directly above both externally-invoked function declarations.
    • No behavior or call paths were modified.
  • Illustrative diff

    // deno-lint-ignore no-unused-vars
    function initializeScript() { ... }
    
    // deno-lint-ignore no-unused-vars
    function ServiceLocatorVar(varName) { ... }

Co-authored-by: tjkilgore93-stack <313495784+tjkilgore93-stack@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the failing GitHub Actions job 'test' Fix Deno test workflow failure from WinDbg entrypoint false positives Sep 17, 2026
Co-authored-by: tjkilgore93-stack <313495784+tjkilgore93-stack@users.noreply.github.com>
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown

check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

Unrecognized words (1)

denoland

These words are not needed and should be removed ADDREF

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:tjkilgore93-stack/terminal.git repository
on the copilot/fix-failing-github-actions-job-test branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/cfb6f7e75bbfc89c71eaa30366d0c166f1bd9c8c/apply.pl' |
perl - 'https://github.com/tjkilgore93-stack/terminal/actions/runs/35179600818/attempts/2' &&
git commit -m 'Update check-spelling metadata'

OR

To have the bot accept them for you, comment in the PR quoting the following line:
check-spelling-bot apply updates.

Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (2028) from .github/actions/spelling/expect/alphabet.txt .github/actions/spelling/expect/expect.txt .github/actions/spelling/expect/web.txt and unrecognized words (1)

Dictionary Entries Covers Uniquely
cspell:cpp/src/lang-keywords.txt 44 3 3
cspell:csharp/csharp.txt 32 2 2
cspell:cpp/src/compiler-clang-attributes.txt 46 2 2
cspell:aws/aws.txt 218 2 2
cspell:python/src/python/python.txt 392 2 2

Consider adding to the extra_dictionaries array (in the .github/actions/spelling/config.json file):

    "cspell:cpp/src/lang-keywords.txt",
    "cspell:csharp/csharp.txt",
    "cspell:cpp/src/compiler-clang-attributes.txt",
    "cspell:aws/aws.txt",
    "cspell:python/src/python/python.txt",

To stop checking additional dictionaries, put (in the .github/actions/spelling/config.json file):

"check_extra_dictionaries": []

Pattern suggestions ✂️ (1)

You could add these patterns to .github/actions/spelling/patterns/693a457aab50e561041bbe8b401cf45ba4001dd0.txt:

# Automatically suggested patterns

# hit-count: 1 file-count: 1
# GitHub actions
\buses:\s+(['"]?)[-\w.]+/[-\w./]+@[-\w.]+\g{-1}

Alternatively, if a pattern suggestion doesn't make sense for this project, add a # to the beginning of the line in the candidates file with the pattern to stop suggesting it.

Notices ℹ️ (1)

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

ℹ️ Notices Count
ℹ️ candidate-pattern 1

See ℹ️ Event descriptions for more information.

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

If the listed items are:

  • ... misspelled, then please correct them instead of using the command.
  • ... names, please add them to .github/actions/spelling/allow/names.txt.
  • ... APIs, you can add them to a file in .github/actions/spelling/allow/.
  • ... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
  • ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@tjkilgore93-stack
tj (tjkilgore93-stack) marked this pull request as ready for review September 17, 2026 05:02
@tjkilgore93-stack
tj (tjkilgore93-stack) merged commit f36a728 into main Sep 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants