Repository navigation
Release 0.1.3: macOS OpenMP-runtime check, GRACE_GENERIC_KERNELS per model load - #15
Merged
Merged
Conversation
…model load - macOS: with PyTorch from PyPI in the same process (two OpenMP runtimes), grace-runtime raises a RuntimeError with the fix (PyTorch from conda-forge) instead of the process aborting with OMP: Error #15. - Python: setting or unsetting GRACE_GENERIC_KERNELS in a running process takes effect with the next GPU model load, with the warning. - LAMMPS guide: the 0.1.3 tag; Kokkos_ENABLE_IMPL_HIP_MALLOC_ASYNC=OFF for an own Kokkos with HIP. See CHANGELOG.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.1.3: the files of the tag 0.1.3 (one commit). Merge with Rebase and merge.
Fixes, and the LAMMPS fork on the current stable LAMMPS.
Fixed
abort with
OMP: Error #15. grace-runtime now raises aRuntimeErrorthat explains the conflict and how to installPyTorch from conda-forge instead. (Not when
KMP_DUPLICATE_LIB_OKis set, as with scikit-learn.)GRACE_GENERIC_KERNELSin a running process now takes effect with the next modelload on the GPU, with the warning. Before, a GPU model loaded earlier was reused and ran the generic kernels without
a warning, or kept them after the variable was unset.
LAMMPS (
grace-runtimebranch of the LAMMPS fork)grace/runtime/kk: GRACE-2L and GRACE-3L withcomm_style tiledwork with the device-side communication of thisLAMMPS version.
pace/kk,pace/extrapolation/kk: the keywordneigh(auto,shared,global) selects where the short neighborlist is kept on the GPU; with
autoa list too large for on-chip memory uses global memory with a warning insteadof stopping the run. On a CPU backend, the styles no longer leak their per-atom energy and stress arrays.
Kokkos_ENABLE_IMPL_HIP_MALLOC_ASYNC=OFF, so thatchunksize autoseesthe freed GPU memory (with it on, GRACE-3L ran about 10 % slower on MI250X).
Changed defaults
RuntimeError(see above).pace/kk: a short neighbor list that does not fit on-chip memory runs in global memory with a warning.Kokkos_ENABLE_IMPL_HIP_MALLOC_ASYNCis OFF for the bundled Kokkos.