Repository navigation
Loosen the whole-day float tolerance to 1e-8 - #53
Merged
Merged
Conversation
Fractional period tails within 1e-8 days of a whole day now round to that day instead of being truncated with a PeriodTruncationWarning. 1e-8 days is under 1 ms, which is already strict for a library whose base unit of time is the day. Co-Authored-By: Claude <noreply@anthropic.com>
j-bryan
force-pushed
the
float-tolerance
branch
from
October 13, 2026 22:13
d8ca4eb to
24952ab
Compare
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #38 (does not close it). Stacked on #52, in stack #51.
What changes
_FLOAT_TOLERANCEindcaf/shared/time.pygoes from 1e-12 to 1e-8. The tolerance decides whether a requested fractional period tail counts as a whole number of days, or as a partial day that is dropped with aPeriodTruncationWarning. 1e-8 days is under 1 ms (and 1e-8 of a year is about 0.3 s), which is still strict for a library whose base unit of time is the day.What users will see: a requested tail within 1e-8 days of a whole day now rounds to that day with no warning.
Testing
Adds reference cases just inside (
14 − 5e-9) and just outside (14 − 2e-8) the new tolerance totest_time_helpers.py.uv run ruff check,uv run ruff format --check,uv run mypy dcaf/, anduv run pytestpass (1015 tests).🤖 Generated with Claude Code