Added - #53
Open
IgnatSergeev wants to merge 1 commit into
Open
Added#53IgnatSergeev wants to merge 1 commit into
IgnatSergeev wants to merge 1 commit into
Conversation
Comment on lines
+16
to
+18
| ConsoleMutex.WaitOne(); | ||
| Console.WriteLine(message); | ||
| ConsoleMutex.ReleaseMutex(); |
There was a problem hiding this comment.
Консоль сама буквально это и делает :) AsyncConsole не нужен
Comment on lines
+12
to
+13
| protected TcpClient Client = new (); | ||
| protected StreamWriter? Writer; |
There was a problem hiding this comment.
- protected-полями лучше вовсе не пользоваться, потомкам нельзя доверять.
- Раз это не-public-поля, они именуются со строчной.
- TcpClient реализует IDisposable, так что и весь класс должен реализовывать IDisposable, и в своём методе Dispose() вызывать Dispose у TcpClient
| } | ||
|
|
||
| AsyncConsole.WriteLine("Disconnected"); | ||
| Environment.Exit(0); |
There was a problem hiding this comment.
Не используйте Environment.Exit, это делает код непереиспользуемым, если надо выйти из чата, не убивая весь процесс, в котором он находится
Comment on lines
+54
to
+57
| private static bool IsConnected(TcpClient client) | ||
| { | ||
| return GetState(client) == TcpState.Established; | ||
| } |
There was a problem hiding this comment.
Suggested change
| private static bool IsConnected(TcpClient client) | |
| { | |
| return GetState(client) == TcpState.Established; | |
| } | |
| private static bool IsConnected(TcpClient client) | |
| => GetState(client) == TcpState.Established; |
| @@ -0,0 +1,12 @@ | |||
| namespace ConsoleNetChat; | |||
|
|
|||
| public class ChatterException : Exception | |||
| } | ||
| } | ||
|
|
||
| break; |
There was a problem hiding this comment.
Компилятор выдаёт предупреждение, что выше while (true) с return, так что управление сюда никогда не попадёт
| server.Disconnect(); | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
Архитектурно ужасно, что этот код в Main-е :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.