Skip to content

fix(*): resolving csp violation in core package #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChronosSF wants to merge 5 commits into from
+23 −7
Closed

fix(*): resolving csp violation in core package #2293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ac6425
fix(*): resolving csp violation in core package
ChronosSF May 28, 2026
992a111
Apply suggestions from code review
ChronosSF May 28, 2026
96eb1b6
Initial plan
Copilot May 28, 2026
65de323
Fix loader CSS dependencies: add infragistics.ui.shared.css to igScro…
Copilot May 28, 2026
6cfeb03
Merge pull request #2294 from IgniteUI/copilot/fix-code-review-comments
ChronosSF May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/css/structure/modules/infragistics.ui.shared.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,4 +471,13 @@ visibility:hidden;
.ui-hidden-phone {
display: none !important
}
}
/* Scroll measurement helper - used by $.ig.util.getScrollWidth/getScrollHeight */
.ui-ig-scroll-measure {
width: 100px;
height: 100px;
position: absolute;
top: -10000px;
left: -10000px;
overflow: scroll;
Comment thread
ChronosSF marked this conversation as resolved.
}
15 changes: 12 additions & 3 deletions src/js/infragistics.loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,10 @@ $.ig.dependencies = [
scripts: [ "$path$/modules/infragistics.ui.scroll.js" ],
locale: [ "$localePath$/infragistics.ui.scroll-$locale$.js" ],
group: $.ig.loaderClass.locale.miscGroup,
css: [ "$path$/structure/modules/infragistics.ui.scroll.css" ],
css: [
"$path$/structure/modules/infragistics.ui.shared.css",
"$path$/structure/modules/infragistics.ui.scroll.css"
],
Comment on lines 245 to +251
description: $.ig.loaderClass.locale.descriptions.scrollDescription
},
{
Expand Down Expand Up @@ -1727,7 +1730,10 @@ $.ig.dependencies = [
dependency: [ { name: "igWidget" } ],
scripts: [ "$path$/modules/infragistics.ui.layoutmanager.js" ],
group: $.ig.loaderClass.locale.layoutGroup,
css: [ "$path$/structure/modules/infragistics.ui.layout.css" ],
css: [
"$path$/structure/modules/infragistics.ui.shared.css",
"$path$/structure/modules/infragistics.ui.layout.css"
],
description: $.ig.loaderClass.locale.descriptions.layoutManagerDescription
},
{
Expand Down Expand Up @@ -1789,7 +1795,10 @@ $.ig.dependencies = [
scripts: [ "$path$/modules/infragistics.ui.splitter.js" ],
locale: [ "$localePath$/infragistics.ui.splitter-$locale$.js" ],
group: $.ig.loaderClass.locale.layoutGroup,
css: [ "$path$/structure/modules/infragistics.ui.splitter.css" ],
css: [
"$path$/structure/modules/infragistics.ui.shared.css",
"$path$/structure/modules/infragistics.ui.splitter.css"
],
description: $.ig.loaderClass.locale.descriptions.splitterDescription
},
{
Expand Down
6 changes: 2 additions & 4 deletions src/js/modules/infragistics.util.jquery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,8 +1112,7 @@

// Returns the width of the vertical scrollbar
$.ig.util.getScrollWidth = function () {
var el = $('<div style="width: 100px; height: 100px; position: absolute; ' +
'top: -10000px; left: -10000px; overflow: scroll"></div>')
var el = $("<div></div>").addClass("ui-ig-scroll-measure")
.appendTo($(document.body)), scrollWidth;
Comment on lines 1114 to 1116
scrollWidth = el[ 0 ].offsetWidth - el[ 0 ].clientWidth;
Comment thread
ChronosSF marked this conversation as resolved.
el.remove();
Expand All @@ -1122,8 +1121,7 @@

// Returns the height of the horizontal scrollbar
$.ig.util.getScrollHeight = function () {
var el = $('<div style="width: 100px; height: 100px; position: absolute; ' +
'top: -10000px; left: -10000px; overflow: scroll"></div>')
var el = $("<div></div>").addClass("ui-ig-scroll-measure")
.appendTo($(document.body)), scrollHeight;
scrollHeight = el[ 0 ].offsetHeight - el[ 0 ].clientHeight;
el.remove();
Expand Down
Loading