Skip to content

docs(angular): consolidate duplicate theming topics into themes/index.mdx - #559

Merged
ChronosSF merged 5 commits into
vnextfrom
simeonoff/theming-overview
Sep 25, 2026
Merged

ChronosSF merged 5 commits into
vnextfrom
simeonoff/theming-overview

Conversation

@simeonoff

@simeonoff simeonoff commented Sep 10, 2026 •

Copy link
Copy Markdown
Member

Closes #558

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in the topic content when it has a valuable update, is new, or is considered preview / beta
  • link to other topics using ./page.mdx or ../relative/path.mdx (.mdx extension required)
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check if links function by running the check-api/mdx npm commands
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo
  • add or update meaningful llms.description metadata and run npm run check:llms-metadata


  • do not resolve requested changes (leave that to the reviewer)

@simeonoff
simeonoff requested a review from ChronosSF September 10, 2026 12:47
@simeonoff simeonoff added theming area: enhancement New feature or request labels Sep 10, 2026

@ChronosSF ChronosSF left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note outside this PR's files: the $enhanced-accessibility row in themes/sass/global-themes.mdx still says it "switches component colors and other properties to more accessible values". The new Accessibility section here is more precise (chart brushes switch to the color-blind set). Worth aligning that row with this wording.

Comment thread docs/angular/src/content/en/components/themes/index.mdx Outdated
Comment thread docs/angular/src/content/en/components/themes/index.mdx
@simeonoff
simeonoff requested a review from ChronosSF September 25, 2026 11:36
@ChronosSF
ChronosSF merged commit bf0c737 into vnext Sep 25, 2026
11 checks passed
@ChronosSF
ChronosSF deleted the simeonoff/theming-overview branch September 25, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: enhancement New feature or request theming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate the two theming topics

2 participants