docs(virtual-scroll): close template gaps and fix Angular accuracy issues - #852
viktorkombov wants to merge 7 commits into
Conversation
- Replace the removed igxForRemote input with igxForTotalItemCount in the igxForOf migration table; igxForRemote was removed in 6.1.0. - Set role="presentation" on igx-virtual-scroll inside igx-list so the items are not nested in a second list, and explain it under Screen Readers / ARIA. - Apply the same changes to the JP topic. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@viktorkombov As you asked, I reviewed the JP wording again with an AI agent. I made a few small improvements, mainly to match the terms used in other JP topics and to make some sentences read more naturally. I committed them to a separate branch and opened #855 against Please merge #855 into this PR when it works for you. |
@jsakamotoIGJP, thanks for reviewing the JP wording and for the improvements! I’ll merge #855 into this PR. |
…e-check docs(jp): align Virtual Scroll terms and wording with other JP topics
- Add virtual-scroll-lt-a.png and the virtual-scroll-do / -do-not pair to the xplat assets and mirror them to the Angular en and jp image folders. - Render the anatomy with the Anatomy component and a numbered legend. - Add the Do/Don't image table after the When to use / When not to use labels, capped at 720px like the Avatar topic. - Remove the markdown Do/Don't text table; its rules are already covered in Getting Started, Usage and Troubleshooting. - Apply the same changes to the JP topic. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…emplate into vkombov/task-851
Closes #851
Summary
Adds the design team's anatomy and Do/Don't images to the Virtual Scroll topic, closes the template gaps from the audit, and fixes Angular inaccuracies found while verifying the topic against igniteui-angular master (22.2.0-rc.1). EN and JP are both updated. JP builds on the native check in #855.
Changes
Images (from design, byte-identical in
docs/xplat/src/assets/images/anddocs/angular/src/content/{en,jp}/images/)anatomy-content-light/virtual-scroll-lt-a.png: rendered with<Anatomy>and a 1–5 legend (host, track, content element, item wrapper, over-scan buffer). The DOM skeletons still follow it.virtual-scroll/virtual-scroll-do.png/virtual-scroll-do-not.png: the standard two-column image table, placed before the When to use / When not to use labels (house-style.md:225-226).Do/Don't content
Template gaps
relatedComponents→["List", "Grid", "Card"](D1).../grids/data-grid.mdx. Related Components: add Data Grid to both platform blocks.Grid→{Platform} Data Grid(house-style entity terminology, B6).DocsAsideimport.Accuracy fixes (verified against source)
igxForRemote(removed in 6.1.0) →igxForTotalItemCount.role="presentation"onigx-virtual-scrollinsideigx-list, so the items aren't nested in a second list. Combo and Simple Combo use the same override. A matching bullet was added under Screen Readers / ARIA.Acceptance criteria
relatedComponentsmatches the linked siblings; WebComponents redirects tabular data to the Data Grid.check-relative-linksreports 0 broken links.IgcVirtualScrollComponentwas missing from thedefineAllComponents()list, butIgcComboComponent.register()registers it as a dependency (combo.ts:149-159,register.ts:6-17). Soigc-virtual-scrollwas still defined; verified at runtime and in tree-shaken bundles. The 7.3.2 changelog's "stayed undefined" is true only forigc-qr-code.keyFunction, element recycling, average-size estimate,nearestalignment; possiblyfixed-item-sizefrom #2382) are tracked in #. Angular has no counterpart.Decisions
relatedComponents: it's an Angular-only directive and isn't named in Do/Don't.Needs product-team confirmation (not changed here)
for-of.mdxanddrop-down-virtual.mdxcall it deprecated, butIgxForOfDirectivehas no@deprecatedtag on master or in 22.2.0-rc.1.LICENSEdoesn't includeigx-virtual-scroll.Release dependencies
JP
JP is updated in this PR on top of the native check in #855. The only new JP text is the five-line anatomy legend, built from terms already used on the page, with the half-width parenthesis style from #855. The image-table header reuses the page's 使用すべき / 使用すべきでない labels. Alt text stays in English, per the JP convention.
Validation
check:llms-metadatapass.check-relative-links(xplat, Angular, generated WebComponents) reports 0 broken links.🤖 Generated with Claude Code
Checklist:
preview/beta./page.mdxor../relative/path.mdx(.mdxextension required)IgxSelectComponent,<igx-combo>code blocksfor the names of classes / tags / propertiescode blockscheck-api/mdxnpm commandsllms.descriptionmetadata and runnpm run check:llms-metadata