fix(ci): catch broken toc.json entries on every PR and after merges - #856
Merged
Merged
Conversation
Contributor
Author
|
@ChronosSF once this is merged, could you make |
ChronosSF
added
💥 status: in-test
ChronosSF
approved these changes
Sep 25, 2026
ChronosSF
added
✅ status: verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #518
Changes
pathsfilter so toc.json-only PRs are checked too, and added apushtrigger formaster/vnextso the branch is re-checked after merges.buildSidebarFromToc()now warns about each toc entry it drops because the target file is missing (it used to drop them silently). WithDOCS_TOC_STRICT=trueit fails the build instead.DOCS_TOC_STRICT=truefor the builds, so a missing target failsbuild-and-verify. Deploy builds only warn.Follow-up
To actually block merging, an admin needs to add
check-relative-linksas a required status check in the "vnext & master" ruleset.