[jp-sync] Sync JP TOC: add QR Code entry - #858
Open
github-actions[bot] wants to merge 6 commits into
Open
github-actions[bot] wants to merge 6 commits into
github-actions[bot] wants to merge 6 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mkamiishi
self-requested a review
September 28, 2026 00:35
mkamiishi
previously approved these changes
Sep 28, 2026
Contributor
|
The required check-relative-links check is failing because the Japanese TOC entry points to inputs/qr-code.mdx, but the corresponding Japanese xplat source does not exist: docs/xplat/src/content/jp/components/inputs/qr-code.mdx The English source exists, but without the Japanese xplat source, the Angular Japanese page is not generated and the TOC entry is dropped from the sidebar. Could you add the Japanese topic or remove this TOC entry until the translation is available? |
The JP TOC entries added by this branch pointed at a page that did not exist, so buildSidebar() dropped them and check-relative-links failed for both the xplat and Angular doc sets. The xplat JP sync that should have produced this page skipped it: run 36129656534 could not determine the changeset in a shallow clone and emitted a noop, which `if-no-changes: ignore` reported as a green run. The workflow fix is separate (#868); this adds the missing translation. Mirrors docs/xplat/src/content/en/components/inputs/qr-code.mdx in full, following the translation rules in .github/workflows/sync-jp-docs-xplat.md: prose translated, `_language: ja` added, and imports, JSX tags and their non-prose attributes, {Token} placeholders and code fences preserved byte-for-byte. QR terminology follows JIS X 0510 (誤り訂正, 位置検出パターン, モジュール). Also restores the trailing newline on jp/toc.json, dropped in d992a98. Both relative link checks now report 0 broken. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original author: Simeon Simeonoff (sim.simeonoff@gmail.com)
Syncs the Japanese Angular documentation TOC with the English change introduced by PR #837 (feat(qr-code): add docs), merge commit
e0c49ec.Files processed
docs/angular/src/content/en/components/toc.jsondocs/angular/src/content/jp/components/toc.jsoninputs/qr-code.mdx,new: true) after the "Badge" entry, mirroring the English TOC addition. Component name kept as "QR Code" (untranslated), consistent with other English-origin component names already in the JP TOC (e.g. "Badge", "Switch", "Mask", "Icon", "Checkbox").Notes
inputs/qr-code.mdxcontent page for the Angular platform is generated at build time fromdocs/xplatsources and is git-ignored underdocs/angular/src/content/{en,jp}/components/inputs/, so it never appears in the diff and requires no manual translation here — only the TOC entry needed to be added.docs/xplat/**) fall outside the scope ofdocs/angular/src/content/en->jpsync.