fix(skills): Fixing sorting strategy example - #2407
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The example has unresolved module-resolution and date/time handling issues.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates the Grid Lite-to-Premium migration skill with an object-based custom sorting strategy example.
Changes:
- Documents the
sort(...)strategy contract. - Replaces the obsolete base-class example.
- Adds
SortingDirectionandvalueResolverguidance.
| File | Description | Findings |
|---|---|---|
skills/igniteui-wc-migrate-grid-lite-to-premium/SKILL.md |
Updates custom sorting migration guidance and example. | Fix the unsupported import path and preserve isDate/isTime flags when calling valueResolver. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Updated import path for SortingDirection and added length-based comparer for sorting. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
kdinev
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues
Closes #
Testing
Checklist