Skip to content

fix(file-input): restore file name ellipsis in non-Material themes - #2411

Open
simeonoff wants to merge 2 commits into
masterfrom
simeonoff/fix-2384
Open

simeonoff wants to merge 2 commits into
masterfrom
simeonoff/fix-2384

Conversation

@simeonoff

Copy link
Copy Markdown
Member

Closes #2384

Description

Add min-width: 0 to the file-names grid item so its 1fr column can shrink.
Regressed in #1713, which moved the ellipsis to an inner span.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Related Issues

Related to #1713

Testing

Included a new test case and visually confirmed the fix.

Checklist

  • My code follows the project's coding standards
  • I have tested my changes locally
  • I have read the contributing guidelines, including the accessibility, dependency and security rules

Closes #2384

Add min-width: 0 to the file-names grid item so its 1fr column can
shrink.

Regressed in #1713, which moved the ellipsis to an inner span.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new test checks overflow but does not verify that an ellipsis appears.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

This PR addresses file-name overflow in the file input component by allowing the names area to shrink in non-Material themes.

Changes:

  • Add min-width: 0 to the file-names grid item.
  • Add an overflow test across all four themes.
File Description
src/​components/​file-input/​themes/​file-input.base.scss Allows the file-names area to shrink.
src/​components/​file-input/​file-input.spec.ts Tests file-name overflow across themes.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/components/file-input/file-input.spec.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The component specification still needs to document the restored behavior and its new test scenario.

Review effort: Balanced
Findings: None

Resolved since last review (1)
Previously missed (1)

In code that hasn't changed since last review

Low severity Document filename ellipsis behavior in file-input spec

src/​components/​file-input/​file-input.spec.ts:169

The new test covers filename ellipsis in all four themes, but src/components/file-input/spec.md still only says filenames are displayed and lists just the two older File type layout scenarios (lines 121–124 and 341–344). Its scenario list says it mirrors the suite (line 331). Please document the fixed-width/ellipsis behavior for long or multiple filenames, add this theme-parameterized case to the scenario list, renumber the later scenarios, and record the spec change in its revision history.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(file-input): text overflow ellipsis missing in non-Material themes

3 participants