fix(qr-code): escalate the error level for a logo, observe aria-label, export xlink:href - #2414
Merged
Merged
Conversation
…, export xlink:href Without error-level, the default M always applied, so a large logo shrank instead of raising the level as documented. Track whether the level was set, and escalate from M for a logo larger than its safe area. An aria-label change alone did not update the SVG title. Observe the attribute and request an update. SVG 1.1 consumers read only xlink:href and dropped the exported logo. Write both href and xlink:href in the export snapshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without error-level, the default M always applied, so a large logo shrank instead of raising the level as documented. Track whether the level was set, and escalate from M for a logo larger than its safe area.
An aria-label change alone did not update the SVG title. Observe the attribute and request an update.
SVG 1.1 consumers read only xlink:href and dropped the exported logo. Write both href and xlink:href in the export snapshot.
Type of Change
Checklist
CHANGELOG.mdentry under[Unreleased]