fix(accordion): skip panels that do not render in the keyboard navigation - #2418
Merged
Merged
Conversation
…tion The arrow keys, Home and End moved the focus to a panel with the hidden attribute or display: none, where focus fails, so the focus stayed on the current panel. The navigation now skips panels that do not render.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Visibility must be checked on the focusable header rather than only the panel host.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Updates accordion keyboard navigation to skip non-rendered panels.
Changes:
- Filters keyboard navigation targets by visibility.
- Adds navigation tests and specification updates.
- Documents the fix in the changelog.
| File | Description |
|---|---|
src/components/accordion/accordion.ts |
Filters navigable panels by visibility. |
src/components/accordion/accordion.spec.ts |
Tests hidden-panel navigation. |
src/components/accordion/spec.md |
Documents visibility behavior. |
CHANGELOG.md |
Records the fix. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fix visibility check for navigable panels. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The arrow keys, Home and End moved the focus to a panel with the hidden attribute or display: none, where focus fails, so the focus stayed on the current panel. The navigation now skips panels that do not render.
Type of Change
Checklist
CHANGELOG.mdentry under[Unreleased]