Skip to content

Remove unused fields #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danlamanna merged 1 commit into from
Sep 14, 2026
Merged

Remove unused fields #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions isic_metadata/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
Age,
AnatomSiteSpecialEnum,
ClinSizeLongDiamMm,
ColorTintEnum,
DermoscopicTypeEnum,
DiagnosisConfirmTypeEnum,
FitzpatrickSkinType,
Expand All @@ -27,7 +26,6 @@
"AnatomSiteEnum",
"AnatomSiteSpecialEnum",
"ClinSizeLongDiamMm",
"ColorTintEnum",
"DermoscopicTypeEnum",
"DiagnosisConfirmTypeEnum",
"DiagnosisEnum",
Expand Down
6 changes: 0 additions & 6 deletions isic_metadata/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,6 @@ class AnatomSiteSpecialEnum(StrEnum):
oral_genital = "oral or genital"


class ColorTintEnum(StrEnum):
blue = "blue"
pink = "pink"
none = "none"


class FitzpatrickSkinType(StrEnum):
type_i = "I"
type_ii = "II"
Expand Down
7 changes: 0 additions & 7 deletions isic_metadata/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
Age,
AnatomSiteSpecialEnum,
ClinSizeLongDiamMm,
ColorTintEnum,
DermoscopicTypeEnum,
DiagnosisConfirmTypeEnum,
FitzpatrickSkinType,
Expand Down Expand Up @@ -248,12 +247,6 @@ class MetadataRow(BaseModel):

unstructured: dict[str, Any] = Field(default_factory=dict, exclude=True)

# Unused and undocumented
marker_pen: bool | None = None
hairy: bool | None = None
blurry: bool | None = None
color_tint: ColorTintEnum | None = None

@computed_field # type: ignore[prop-decorator]
@property
def diagnosis_1(self) -> str | None:
Expand Down
8 changes: 0 additions & 8 deletions isic_metadata/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ class Field:
FIELD_REGISTRY: dict[str, Field] = {}

for field in [
"blurry",
"hairy",
"marker_pen",
"personal_hx_mm",
"family_hx_mm",
"melanocytic",
Expand All @@ -47,7 +44,6 @@ class Field:
"tbp_tile_type",
"mel_mitotic_index",
"anatom_site_special",
"color_tint",
"patient_id",
"lesion_id",
"rcm_case_id",
Expand Down Expand Up @@ -189,12 +185,8 @@ class Field:

for field in FIELD_REGISTRY: # noqa: PLC0206
if field in [
"blurry",
"color_tint",
"dermoscopic_type",
"hairy",
"image_type",
"marker_pen",
"image_manipulation",
]:
FIELD_REGISTRY[field].type = "acquisition"
Expand Down