Skip to content

Require mel_thick_mm to be non-negative #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danlamanna merged 1 commit into from
Sep 14, 2026
Merged

Require mel_thick_mm to be non-negative #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions isic_metadata/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ class MetadataRow(BaseModel):
Decimal,
BeforeValidator(MelThickMm.parse_measurement_str),
Field(max_digits=5, decimal_places=2),
Ge(0),
]
| None
) = None
Expand Down
9 changes: 9 additions & 0 deletions tests/test_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,15 @@ def test_mel_thick_mm_invalid() -> None:
assert "Unable to parse value as a number" in convert_errors(excinfo.value)[0]["msg"]


@given(mel_thick=st.integers(min_value=-99999, max_value=-1).map(lambda x: Decimal(x) / 100))
def test_mel_thick_mm_negative(mel_thick: Decimal) -> None:
for value in [mel_thick, str(mel_thick)]:
with pytest.raises(ValidationError) as excinfo:
MetadataRow.model_validate({"diagnosis": "Melanoma Invasive", "mel_thick_mm": value})
assert len(excinfo.value.errors()) == 1
assert excinfo.value.errors()[0]["type"] == "greater_than_equal"


@given(
clin_size=st.one_of(
# keep max values bounded so they don't generate larger than representable decimals.
Expand Down