Skip to content

Validate falsy melanoma field values against diagnosis #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danlamanna merged 1 commit into from
Sep 14, 2026
+5 −1
Merged

Validate falsy melanoma field values against diagnosis #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion isic_metadata/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ def validate_melanoma_fields(self) -> MetadataRow:
]

for field in melanoma_fields:
if not getattr(self, field):
if getattr(self, field) is None:
continue

if not self.diagnosis:
Expand Down
4 changes: 4 additions & 0 deletions tests/test_dependent_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,12 @@
("field_name", "field_value"),
[
("mel_mitotic_index", "4/mm^2"),
("mel_mitotic_index", "0/mm^2"),
("mel_thick_mm", "4mm"),
("mel_thick_mm", "0mm"),
("mel_thick_mm", 0),
("mel_ulcer", True),
("mel_ulcer", False),
],
)
def test_melanoma_fields_require_melanoma_diagnosis(
Expand Down