Repository navigation
Bump version to 1.9.4 for NumPy 2 / Linux sdist fix - #1
Closed
IncubatorShokuhou wants to merge 1 commit into
Closed
IncubatorShokuhou wants to merge 1 commit into
IncubatorShokuhou wants to merge 1 commit into
Conversation
Unreleased master already includes CyanideCN#147 (PEP 517 pyproject.toml + force Cython .pyx builds), which fixes Linux sdist installs under NumPy 2. PyPI is still 1.9.3. Bump version so a source/wheel release can ship the fix; no other code changes. Co-authored-by: Hao Lyu <IncubatorShokuhou@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target: this bump is meant for upstream
CyanideCN/PyCINRAD. Open the cross-repo PR from:https://github.com/CyanideCN/PyCINRAD/compare/master...IncubatorShokuhou:PyCINRAD:cursor/numpy2-linux-build-859a?expand=1
(The automation here can only open a PR on this fork; the branch is already pushed and is 1 commit ahead of upstream
master.)Why
#147 (
94adb2b) already fixed Linux source builds:pyproject.tomlwith setuptools / numpy / cython build-system requires.pyx(no vendored.cfallback)That is unreleased. Git
masteris still1.9.3. PyPI latest is also 1.9.3 (2026-01-02), which predates the CyanideCN#147 merge (2026-05-26). On Linux there are no manylinux wheels, sopip install cinradstill downloads the broken sdist.This PR only bumps
1.9.3→1.9.4in the same three places as previous releases (cinrad/__init__.py,setup.py,docs/conf.py) so a tagged PyPI release can ship the fix. No functional code changes. 1.9.4 would also include already-merged CyanideCN#148 and CyanideCN#149.PyPI still broken (verified)
FAIL (
pypi_install_exit=1):PyPI 1.9.3 files: Windows cp310–cp314 wheels +
cinrad-1.9.3.tar.gzonly. No Linux wheel.Current master works (verified on Linux / Python 3.12 / NumPy 2.5.3)
HEAD tested:
ca9ccd9(use fmax to calc (#148)), which includes CyanideCN#147.A. Isolated
python -m build(sdist + wheel)Clean venv with only
build(no numpy). PEP 517 isolation installedcython==3.3.0,numpy==2.5.3,setuptools==84.0.0.PASS —
cinrad-1.9.3.tar.gz+cinrad-1.9.3-cp312-cp312-linux_x86_64.whl. Sdist containspyproject.toml;setup.pyusesext_suffix = ".pyx".B. Install wheel into a clean NumPy 2 venv
From a directory outside the repo (so
sys.pathdoes not pick up the source tree):import cinrad1.9.3, site-packages;_utils/_unwrap_2d.soloaded)pytest test/10 passedC.
pip installthe built sdist (Linux-from-source path)PASS — wheel rebuilt;
import cinradOK;pytest10 passed; extension smoke OK on NumPy 2.5.3.Workaround until 1.9.4 is on PyPI
or
pip install .from a clone (usespyproject.toml).Request
Please tag
v1.9.4and upload a new sdist (and wheels if convenient). Linux users currently cannotpip install cinradunder modern pip + NumPy 2. I did not add a CHANGELOG file because the repo has never kept one.