Skip to content

Feature request: opt-in "fully enclosed" (contains) mode for drag-selection - #1166

Merged
jesusmpc merged 3 commits into
mainfrom
feature/GH-1158-feature-request-opt-in-fully
Sep 7, 2026
Merged

jesusmpc merged 3 commits into
mainfrom
feature/GH-1158-feature-request-opt-in-fully

Conversation

@jesusmpc

@jesusmpc jesusmpc commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Closes #1158

Add selectionMode: 'intersects' | 'contains' to the nodes-selection
plugin config. Default stays 'intersects' (unchanged behavior); when
set to 'contains', a node is selected via drag-selection only if its
bounding box is fully enclosed by the selection rectangle. Group nodes
are checked against their own outer bounding box, not per child.

Frame nodes keep their existing always-contains behavior regardless
of selectionMode.

Closes #1158

Signed-off-by: Jesus Manuel Piñeiro Cid <jesusmpc@inditex.com>
@jesusmpc jesusmpc self-assigned this Sep 7, 2026
@jesusmpc
jesusmpc marked this pull request as ready for review September 7, 2026 14:35
@jesusmpc
jesusmpc requested a review from a team as a code owner September 7, 2026 14:35
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

❗ This Pull Request will not trigger a docs release

A Pull Request with no docs/release label will not trigger a docs site release — label it docs/release if you want this merge to release the docs site.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Release Preview Success

You are going to release the version minor with the following changes:

5.3.0 - 2026-09-07

Added

  • #1158 Opt-in "fully enclosed" (contains) mode for drag-selection

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (feature/GH-1158-feature-request-opt-in-fullymain).

@jesusmpc
jesusmpc force-pushed the feature/GH-1158-feature-request-opt-in-fully branch from 7c95a57 to 536a846 Compare September 7, 2026 14:37
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

❗ This Pull Request will not trigger a docs release

A Pull Request with no docs/release label will not trigger a docs site release — label it docs/release if you want this merge to release the docs site.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Release Preview Success

You are going to release the version minor with the following changes:

5.3.0 - 2026-09-07

Added

  • #1158 Opt-in "fully enclosed" (contains) mode for drag-selection

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (feature/GH-1158-feature-request-opt-in-fullymain).

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Docs Release Preview

Merging this Pull Request will release the docs site as docs/v5.2.2.

⚠️ Tag already exists

docs/v5.2.2 already exists and will be force-overwritten on merge.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Release Preview Success

You are going to release the version minor with the following changes:

5.3.0 - 2026-09-07

Added

  • #1158 Opt-in "fully enclosed" (contains) mode for drag-selection

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (feature/GH-1158-feature-request-opt-in-fullymain).

Signed-off-by: Jesus Manuel Piñeiro Cid <jesusmpc@inditex.com>
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Docs Release Preview

Merging this Pull Request will release the docs site as docs/v5.3.0.

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Release Preview Success

You are going to release the version minor with the following changes:

5.3.0 - 2026-09-07

Added

  • #1158 Opt-in "fully enclosed" (contains) mode for drag-selection

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (feature/GH-1158-feature-request-opt-in-fullymain).

@sonarqubecloud

sonarqubecloud Bot commented Sep 7, 2026

Copy link
Copy Markdown

@jesusmpc
jesusmpc merged commit f406412 into main Sep 7, 2026
20 of 21 checks passed
@jesusmpc
jesusmpc deleted the feature/GH-1158-feature-request-opt-in-fully branch September 7, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: opt-in "fully enclosed" (contains) mode for drag-selection

1 participant