Skip to content

Support hyperlinks on text nodes: make the whole text clickable to a defined URL - #1168

Merged
jesusmpc merged 3 commits into
mainfrom
feature/GH-1167-support-hyperlinks-on-text-n
Sep 9, 2026
Merged

Support hyperlinks on text nodes: make the whole text clickable to a defined URL#1168
jesusmpc merged 3 commits into
mainfrom
feature/GH-1167-support-hyperlinks-on-text-n

Conversation

@jesusmpc

@jesusmpc jesusmpc commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Closes #1167

Text nodes gain a link attribute (http/https only) that makes the
whole text clickable and forces underline + link colouring while set.

- setLink()/getLink()/removeLink() public API on WeaveTextNode
- click-tap.ts gains a generic per-node click() hook, since selected
  nodes' hit area is covered by the Transformer overdraw shape
- true fill/textDecoration are captured (linkPreviousFill/
  linkPreviousTextDecoration) and restored by serialize() so they
  survive resize/drag/edit while linked
- Ctrl/Cmd+Click opens immediately; a plain click opens only when the
  node was already selected, debounced against double-click (edit mode)
- CONTRIBUTING.md documents the CHANGELOG entry format
- CHANGELOG + api-reference docs updated

Closes #1167

Signed-off-by: Jesus Manuel Piñeiro Cid <jesusmpc@inditex.com>
@jesusmpc
jesusmpc marked this pull request as ready for review September 8, 2026 06:13
@jesusmpc
jesusmpc requested a review from a team as a code owner September 8, 2026 06:13
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Docs Release Preview

Merging this Pull Request will release the docs site as docs/v5.3.1.

1 similar comment
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Docs Release Preview

Merging this Pull Request will release the docs site as docs/v5.3.1.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Release Preview Success

You are going to release the version minor with the following changes:

5.4.0 - 2026-09-08

Added

  • #1167 Support hyperlinks on text nodes: make the whole text clickable to a defined URL

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (feature/GH-1167-support-hyperlinks-on-text-nmain).

@jesusmpc
jesusmpc force-pushed the feature/GH-1167-support-hyperlinks-on-text-n branch from bae694a to 3bb1d2b Compare September 8, 2026 06:14
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Docs Release Preview

Merging this Pull Request will release the docs site as docs/v5.3.1.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Release Preview Success

You are going to release the version minor with the following changes:

5.4.0 - 2026-09-08

Added

  • #1167 Support hyperlinks on text nodes: make the whole text clickable to a defined URL

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (feature/GH-1167-support-hyperlinks-on-text-nmain).

Unreleased now contains a feature addition (#1167), so the next
release is a minor bump, not the previously-set 5.3.1 patch.

Signed-off-by: Jesus Manuel Piñeiro Cid <jesusmpc@inditex.com>
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Release Preview Success

You are going to release the version minor with the following changes:

5.4.0 - 2026-09-08

Added

  • #1167 Support hyperlinks on text nodes: make the whole text clickable to a defined URL

💡 Merge Strategy: Squash and Merge

Remember to use the 'Squash and Merge' strategy to merge this Pull Request (feature/GH-1167-support-hyperlinks-on-text-nmain).

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Docs Release Preview

Merging this Pull Request will release the docs site as docs/v5.4.0.

@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

@jesusmpc
jesusmpc merged commit a5a5702 into main Sep 9, 2026
20 of 21 checks passed
@jesusmpc
jesusmpc deleted the feature/GH-1167-support-hyperlinks-on-text-n branch September 9, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support hyperlinks on text nodes: make the whole text clickable to a defined URL

1 participant