Repository navigation
knowledge: qwen-omni is owned by amy-why-3459 alone - #153
Merged
Merged
Conversation
psv666 reports (#139) that the bot mentions them on qwen2.5-omni issues for a module they do not own. The mention comes from this page's row, which ReviewBot's model_owners.json mirrors: one `qwen-omni` entry whose alias list spans both qwen2.5-omni and qwen3-omni, carrying two owners. Only the negative claim is evidenced, so only it is applied. Across vllm-project/vllm-omni since 2026-05, psv666 authored nothing under `qwen2_5_omni*` or `qwen3_omni*`; amy-why-3459 authored 16 commits under `qwen3_omni*` and remains the owner. Whether qwen2.5-omni deserves its own row with its own owner is a question for the people who own it, not something this page can answer from commit history; #139 stays open for it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KT4EvUTzzLeq243DG6T1mC
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#139: the bot mentions
@psv666on qwen2.5-omni issues, a module they do not own.The mention originates in this knowledge page.
knowledge/repos/vllm-omni/owners/model_owner.mdcarries one
qwen-omnirow with two owners, and ReviewBot'ssrc/omni_reviewbot/model_owners.jsonmirrors it with an alias list(
qwen-omni,qwen_omni,qwen omni,qwen2.5-omni,qwen2_5_omni) that spanstwo distinct models. Every qwen2.5-omni issue therefore mentions both owners.
What this changes
The
qwen-omnirow now readsamy-why-3459 | 吴海燕.Only the negative claim is evidenced, so only it is applied. In
vllm-project/vllm-omni since 2026-05, psv666 authored nothing under
qwen2_5_omni*or
qwen3_omni*; amy-why-3459 authored 16 commits underqwen3_omni*.What this deliberately does not change
Whether qwen2.5-omni should be its own row with its own owner is a question for
the people who own it — commit history cannot answer it. #139 stays open for
that decision.
The two catalogs are still duplicated with nothing enforcing agreement between
them; the ReviewBot half of this correction ships separately in
JiusiServe/omni-reviewbot (one fix, one PR).
Verification
python -m pytest -qwithPYTHONPATHpinned to this worktree (a bare pytesthere silently tests the stale top-level checkout). One pre-existing local failure,
test_phase1_cluster.py::test_drift_guard_unimportable_checked_class_fails_guard,is an artifact of vllm being importable on this machine — it fails identically on
origin/mainand does not run in CI's environment. No other failures.🤖 Generated with Claude Code
https://claude.ai/code/session_01KT4EvUTzzLeq243DG6T1mC