rebase: surface assertions an infra-failed run already reported

doc/architecture/SPEC/rebase_engine.md

@@ -1,6 +1,6 @@
 # rebase_engine/ —— 规范
 
-<!-- verified-against: 2026-09-19 -->
+<!-- verified-against: 2026-09-21 -->
 
 `LOC ~7500（26 个模块） · repo-rebase-v3 的原生 rebase 引擎 · refactor-status: ok`
 
@@ -144,3 +144,13 @@ provider；两条路径共用同一 prompt、同一工具面与同一 plan gate
 循环而不是判 module 失败——但重启会丢掉已积累的上下文，所以预算过低时
 agent 会反复从头探索。flash 级模型在同一 module 上约需 pro 级 2.3 倍轮次
 （140+ vs 62），150 的旧上限会被截断三次仍未完成。
+
+## 结构性失败仍要报告已产生的断言（2026-09-21）
+
+`test_loop` 把 timeout / watchdog kill / harness crash 归为**结构性**失败：
+不进 `failed_tests`、不做 baseline 对比、push gate 直接阻断——这部分不变。
+但结构性结束**不等于**这次运行什么都没发现：一个 suite 可能先报了断言失败
+再被杀掉。那些 node id 过去随 output 一起丢弃，报告只剩"1 个 infra 失败"。
+现在 infra 记录里会带上已报告的断言 id（复用 `ci_loop.extract_failed_test_ids`）。
+实例：2026-09-19 `simple_diffusion_test` 超时前已报 10 个量化断言失败，全部不可见，
+直到 Buildkite #3055 重新发现。

src/infermatrix_copilot/rebase_engine/test_loop.py

@@ -27,8 +27,33 @@
 
 from .substate import Substate
 
+
+from .ci_loop import extract_failed_test_ids
+
 log = logging.getLogger(__name__)
 
+def _log_text(output: str) -> str:
+    """Return the log CONTENTS for `TestRunResult.output`.
+
+    `output` carries either the log text or a PATH to the log file — the
+    production caller (`engine/steps/rebase_v3._to_result`) passes
+    `outcome.log_file`. Parsing the pathname finds nothing, so read the file
+    when it is one. A read failure must never change the structural
+    classification, so it degrades to "no ids found".
+    """
+    if not output:
+        return ""
+    if "\n" not in output and len(output) < 4096:
+        try:
+            candidate = Path(output)
+            if candidate.is_file():
+                return candidate.read_text(errors="replace")
+        except OSError:
+            return ""
+    return output
+
+
+
 
 @dataclass(frozen=True)
 class TestRunResult:
@@ -141,9 +166,27 @@ def checkpoint(current: str = "") -> None:
             # STRUCTURAL (Rev 8 §2.3): timeouts / watchdog kills / harness
             # crashes never enter the baseline-vs-regression split or the
             # assertion pass-through — the push gate blocks on these
+            #
+            # A structural end does NOT mean the run produced no findings: a
+            # suite can report assertion failures and THEN be killed. Those
+            # ids were previously discarded with the output, so the report
+            # read "1 infra failure" while the log held real regressions
+            # (observed 2026-09-19: simple_diffusion_test timed out after 10
+            # quantization assertions, all invisible until CI re-found them).
+            # Surface them in the record; the classification is unchanged.
+            found = sorted(extract_failed_test_ids(_log_text(result.output)))
+            detail = f"{slug}: {result.infra}"
+            if found:
+                shown = ", ".join(found[:5])
+                more = f" (+{len(found) - 5} more)" if len(found) > 5 else ""
+                detail += (f" — {len(found)} assertion failure(s) reported "
+                           f"before the structural end: {shown}{more}")
+                log.warning("  INFRA FAILURE (%s) with %d assertion "
+                            "failure(s) already reported: %s", result.infra,
+                            len(found), shown)
             log.warning("  INFRA FAILURE (%s): %s (rc=%d)", result.infra,
                         label, result.rc)
-            infra_failures.append(f"{slug}: {result.infra}")
+            infra_failures.append(detail)
             infra_slugs.add(slug)
             failed += 1
             checkpoint()

test/test_assembly.py

@@ -263,6 +263,108 @@ def baseline_fn(slug):
     assert result2["infra_failures"] == ["timeout: timeout"]
 
 
+def test_infra_failure_surfaces_assertions_it_already_reported(tmp_path):
+    """A structural end does not mean the run found nothing.
+
+    A suite can report assertion failures and THEN be killed. The loop must
+    keep the STRUCTURAL classification (out of `failed_tests`, push gate
+    blocks) while still naming the ids in the record -- otherwise the report
+    reads "1 infra failure" and real regressions stay invisible.
+
+    Regression test for 2026-09-19: simple_diffusion_test timed out after
+    reporting 10 quantization assertion failures; all 10 were dropped with
+    the output and only CI re-found them.
+    """
+    sub = Substate(tmp_path, "run-surface")
+    jobs = [{"slug": "killed", "label": "killed", "min_gpus": 1}]
+    output = (
+        "FAILED tests/diffusion/models/glm_image/test_q.py::TestA::test_one\n"
+        "FAILED tests/diffusion/models/glm_image/test_q.py::TestB::test_two\n"
+        "[watchdog/kill] tier=1 test=killed\n"
+    )
+    runs = {"killed": tl.TestRunResult(1, output=output, infra="timeout")}
+
+    async def debug_fn(slug, label, rc, out):
+        return False
+
+    result = asyncio.run(tl.run_test_loop(
+        jobs, substate=sub, run_fn=lambda s: runs[s],
+        baseline_fn=lambda s: tl.TestRunResult(0), debug_fn=debug_fn))
+
+    # classification is unchanged: still structural, still not an assertion
+    assert result["failed_tests"] == []
+    assert result["failed"] == 1
+    record = result["infra_failures"][0]
+    assert record.startswith("killed: timeout")
+    # ...but the findings it DID produce are now named
+    assert "2 assertion failure(s)" in record
+    assert "TestA::test_one" in record and "TestB::test_two" in record
+
+
+def test_infra_failure_reads_assertions_from_a_log_PATH(tmp_path):
+    """The production caller passes a PATH, not log text.
+
+    `engine/steps/rebase_v3._to_result` sets TestRunResult.output to
+    `outcome.log_file`. Parsing the pathname finds nothing, so the loop must
+    read the file -- otherwise this surfacing never fires for the real
+    timeout/watchdog runs it exists for.
+    """
+    sub = Substate(tmp_path, "run-path")
+    log_file = tmp_path / "simple_diffusion_test.log"
+    log_file.write_text(
+        "collected 5802 items\n"
+        "FAILED tests/diffusion/models/glm_image/test_q.py::TestA::test_one\n"
+        "FAILED tests/diffusion/models/minimax_h3/test_c.py::test_two\n"
+        "[watchdog/kill] tier=1 test=simple_diffusion_test\n"
+    )
+    jobs = [{"slug": "killed", "label": "killed", "min_gpus": 1}]
+    runs = {"killed": tl.TestRunResult(1, output=str(log_file), infra="timeout")}
+
+    async def debug_fn(slug, label, rc, out):
+        return False
+
+    result = asyncio.run(tl.run_test_loop(
+        jobs, substate=sub, run_fn=lambda s: runs[s],
+        baseline_fn=lambda s: tl.TestRunResult(0), debug_fn=debug_fn))
+    record = result["infra_failures"][0]
+    assert "2 assertion failure(s)" in record
+    assert "TestA::test_one" in record
+    assert result["failed_tests"] == []          # still structural
+
+
+def test_infra_failure_unreadable_log_stays_structural(tmp_path):
+    """An unreadable/missing log must not change the classification."""
+    sub = Substate(tmp_path, "run-unreadable")
+    jobs = [{"slug": "gone", "label": "gone", "min_gpus": 1}]
+    missing = str(tmp_path / "does_not_exist.log")
+    runs = {"gone": tl.TestRunResult(1, output=missing, infra="timeout")}
+
+    async def debug_fn(slug, label, rc, out):
+        return False
+
+    result = asyncio.run(tl.run_test_loop(
+        jobs, substate=sub, run_fn=lambda s: runs[s],
+        baseline_fn=lambda s: tl.TestRunResult(0), debug_fn=debug_fn))
+    assert result["infra_failures"] == ["gone: timeout"]
+    assert result["failed_tests"] == []
+
+
+def test_infra_failure_without_assertions_is_unchanged(tmp_path):
+    """A genuine infra-only failure keeps the original terse record."""
+    sub = Substate(tmp_path, "run-terse")
+    jobs = [{"slug": "oom", "label": "oom", "min_gpus": 1}]
+    runs = {"oom": tl.TestRunResult(1, output="Killed\n", infra="timeout")}
+
+    async def debug_fn(slug, label, rc, out):
+        return False
+
+    result = asyncio.run(tl.run_test_loop(
+        jobs, substate=sub, run_fn=lambda s: runs[s],
+        baseline_fn=lambda s: tl.TestRunResult(0), debug_fn=debug_fn))
+    assert result["infra_failures"] == ["oom: timeout"]
+
+
+
 # -- CI build ledger + monitor -------------------------------------------------
 
 class FakeCI: