Repository navigation
Separate PR review refinement from step orchestration - #192
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR review step still mixed draft generation with several bounded post-draft passes: residual promotion, coverage mining, a targeted second round, and per-comment verification. Their ordering affects which findings survive, but those passes have no reason to own step registration or final publication decisions.
Move the passes into
review.refinementand expose onerefine_reviewcall to the registered review step. The step retains evidence assembly, depth selection, final disposition, comment budget, and result projection. The refinement component accepts the frozen diff and tool context, applies the passes in their existing order, and has no GitHub publishing effect. Update the architecture SPEC and direct helper tests to the new owner.Validation: complete local Copilot suite; focused review, ensemble and render tests; strict SPEC freshness;
ruff check --select F821,F401;git diff --check.