Skip to content

Defer workflow-step imports until registry assembly - #194

Merged
tzhouam merged 2 commits into
mainfrom
codex/lazy-step-registration-20260926
Sep 26, 2026
Merged

tzhouam merged 2 commits into
mainfrom
codex/lazy-step-registration-20260926

Conversation

@tzhouam

@tzhouam tzhouam commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator

Importing infermatrix_copilot.engine.steps currently imports all eight workflow domains immediately, including mutation steps, even when a caller only needs the registry facade. This defers those vetted imports until register_builtin_steps assembles a registry. Step decorators and names remain with their definitions, and each new registry still receives the same built-in set. A subprocess test checks that package import is inert and explicit assembly loads the domains.

The step SPEC and architecture tour now describe the actual import boundary. Validation: 83 focused assembly/engine/review tests, 1,529 full local tests, and strict SPEC freshness (79 declared-verified pages, no stale or uncovered modules). The local environment lacks the optional build module, so the repository CI is the installed-wheel gate.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T08:15:35.986873Z 7e669bb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tzhouam
tzhouam merged commit 1addff2 into main Sep 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant