Repository navigation
Move durable run reservation below Copilot orchestration - #195
Merged
Merged
Conversation
tzhouam
marked this pull request as ready for review
September 26, 2026 09:35
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunServicepreviously reached through the largeCopilotworkflow orchestrator to reserve a run and validate IDs for polling. That made durable-run identity and idempotent retry state appear to belong to workflow execution even though SDK/MCP callers need them independently.app.reservation.RunReservationnow owns the existing on-disk reservation, keyed retry, checkout binding, and contained run-ID behavior.RunServicecalls it directly for reserve and poll;Copilotretains its methods as compatibility delegates for existing callers and child execution. The request/status schema, run IDs, worker claim, and execution path are unchanged. The SPEC pages describe the new ownership.Validation: focused reservation/MCP/SDK/contract/lifecycle tests and the full local pytest suite passed. Strict SPEC freshness, doc links/citations, and
git diff --checkpassed. A built wheel containsapp/reservation.py; importing it from the wheel does not import the orchestrator or transports. Exact-head GitHub CI is still required before merge.