Repository navigation
Enable vLLM-GR agent reviews through packaged owner routes - #244
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 98a3f6d473
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| scope_prefixes: | ||
| - vllm_gr/v1/attention/ |
There was a problem hiding this comment.
When a PR has a generic title and changes only the documented focused test—for example tests/test_beam_attention_metadata.py—none of these scope prefixes match, so direct_review_plan() returns no knowledge route (needs_pr_context) instead of the attention owner. The same gap affects the focused engine, BeamProc, and serving tests, while packaging already routes tests/packaging/; add the stable focused test paths to their corresponding owner scopes so test-only GR reviews receive the relevant review map.
Useful? React with 👍 / 👎.
| aliases: | ||
| - vllm-gr | ||
| - vllm_gr | ||
| - JiusiServe/vllm-gr |
There was a problem hiding this comment.
When an SDK caller uses the newly declared JiusiServe/vllm-gr alias as RepositoryRef.alias, DirectClient._request_values() rejects it as unsupported before adapter normalization because it compares only against canonical names from supported_repositories. The MCP path accepts this identifier, and the parity test masks the discrepancy by passing vllm-gr to the SDK but the full name only to direct_review_plan(); either make the SDK honor adapter aliases or stop advertising this value as an alias.
Useful? React with 👍 / 👎.
GR agent reviews fail before model execution with
unsupported repository: 'vllm-gr', as seen in review job 150 for JiusiServe/vllm-gr#424. Add the packaged GR adapter, repository entry and compact owner maps so the existing Direct SDK can plan GR reviews and keep its pinned-head completion gate.The source maps cover EngineCore, Rust BeamProc, serving, attention and packaging at main commit
a05103dc16c7b8dfd2213b73c5ee2d4f28cb6fee. No provider runtime code changes.Validation: 79 focused SDK/contract tests pass; both knowledge validators pass; an installed-wheel smoke accepts GR and returns EngineCore/BeamProc routes. CI also checks GR is advertised by the installed wheel.