Repository navigation
kb init: afd-plugin init config (pilot 1) - #245
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Add a knowledge_lifecycle.init block to the afd-plugin adapter so `kb init afd-plugin` can run. The lifecycle stays enabled: false / shadow; kb init's third PR flips it after human review. - source_roots: afd_plugin/ only. csrc/ is C++/CUDA and the Python module scan does not read it. - exclude: package __init__.py and py.typed markers. - seeds (three, each justified inline): general/review/rules.md and general/review/guides/upstream-first-for-algorithm.md are linked; repos/vllm-omni/rebase/upstream-api-drift.md is adapt-copied because afd_plugin/compat and the v1 worker subclasses track vLLM releases. - Everything else keeps the InitConfig defaults. test_kb_init_pilot_afd.py loads the real adapter through load_registry and checks that the block parses and every seed exists in the real tree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tzhouam
force-pushed
the
kb/init-afd-plugin-config
branch
from
September 30, 2026 15:31
82c56e7 to
20fc93c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This adds a
knowledge_lifecycle.initblock toadapters/afd_plugin/manifest.yamlso thatkb init afd-plugin(pilot 1, design kb-init §12) has its inputs. The lifecycle itself staysenabled: false, mode: shadow; kb init's third PR flips it after human review.Upstream facts (vllm-project/afd-plugin, checked 2026-09-30)
main, Python.afd_plugin/holds 79.pyfiles.csrc/is C++/CUDA (gpu/npu). Docs are underdocs/(15.md), plusREADME.mdandAGENTS.md, all covered by the defaultdoc_globs.Chosen values
source_roots: [afd_plugin/].csrc/is left out because the Python module scan cannot read it; its knowledge stays with the existing execution-platforms owner.exclude: ["*/__init__.py", "*/py.typed"].InitConfigdefault: depth 2, min 300 LOC, 200 PRs / 180 days, coverage 0.85, $30 budget.Seeds (kept few, each justified inline)
general/review/rules.mdgeneral/review/guides/upstream-first-for-algorithm.mdrepos/vllm-omni/rebase/upstream-api-drift.mdafd_plugin/compat/**and the v1 worker subclasses track vLLM releases, so the drift patterns transfer; kb init drops any claim that doesn't resolve in afd-pluginTests
test/test_kb_init_pilot_afd.pyloads the real adapter viaload_registryand asserts the init block parses,source_roots, and thatvalidate_seedspasses on the real knowledge tree.imc-check.sh(full pytest, doc linters, SPEC freshness--strict, knowledge linters) returns rc=0.20260930T102017.412851Z-3ea89bed1f-codeloop-i1-approve-725ozuat.md).Stacked on kb/init-integration (#239…#243); retarget to main after those merge.
🤖 Generated with Claude Code