Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4bc2844e88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| schema_version: 1 | ||
| owners: | ||
| - owner: components | ||
| path: repos/afd-plugin/components/_index.md |
There was a problem hiding this comment.
Preserve adapter coverage before enabling this route table
Adding a nonempty _routes.yaml makes _direct_knowledge_routes bypass the existing AFD adapter mapping, but this table omits established paths such as afd_plugin/config.py, afd_plugin/v1/worker/attention_worker.py, and afd_plugin/v1/worker/ffn_worker.py. For a PR with a generic description, each of those now returns description_unrouted with no route or scope validation, and PYTHONPATH=src pytest -q test/test_knowledge_view_routing.py::test_golden_routes_unchanged_by_extraction fails for both AFD fixtures. Because Direct reviews consume only the exact routes returned, either retain the adapter fallback or make this table reach parity before activating it.
AGENTS.md reference: knowledge/AGENTS.md:L16-L16
Useful? React with 👍 / 👎.
|
|
||
| # AFD plugin 评审规则:上游漂移与跨文档隐含不变量 | ||
|
|
||
| ## AFD-I15 — 保持 CPU-safe 导入边界,CUDA/Ascend 类互不继承 |
There was a problem hiding this comment.
Move seeded conclusions to their nearest owner rules
Do not keep this repository-root seed page as a catch-all: its rules span plugin-boundary/CPU imports (AFD-I15), connectors (I16–I17), execution platforms (I18/I23), compatibility (I20/I22), and CI (I24), despite those owners already having dedicated directories, and several conclusions duplicate the new root rules (for example I15 versus I10/I11 and I20 versus I7). This both leaves the rules outside the exact component routes and creates competing copies that can drift; merge each conclusion union-first into the nearest owner's rules.md and remove the heterogeneous seed page.
AGENTS.md reference: AGENTS.md:L11-L17
Useful? React with 👍 / 👎.
|
Closing: this bootstrap PR fails CI for a reason that is a kb init defect, not a content problem, so it will be regenerated rather than hand-fixed. afd-plugin is routed by its adapter manifest ( Fix (kb init): for a manifest-routed repository, never write |
kb initstage skeleton forafd-plugin(vllm-project/afd-plugin).9cae2d2ddaae7e1752fc12ead577d59540b17f273118067936332f671dcd8b7281ad6f8150adc103Human-merged. Rules were screened by the docs redundancy filter, checked at the pin, and given an advisory verdict;
failrules are already removed.repos/afd-plugin/rules.mdrepos/afd-plugin/rules.mdrepos/afd-plugin/rules.mdrepos/afd-plugin/rules.mdrepos/afd-plugin/rules.mdrepos/afd-plugin/rules.mdrepos/afd-plugin/rules.mdrepos/afd-plugin/rules.mdrepos/afd-plugin/rules.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdrepos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.mdSeeds (adapted, provenance only here):
repos/vllm-omni/rebase/upstream-api-drift.md@311806793633→repos/afd-plugin/rules-seed-vllm-omni-rebase-upstream-api-drift.md(AFD-I13, AFD-I14, AFD-I15, AFD-I16, AFD-I17, AFD-I18, AFD-I19, AFD-I20, AFD-I21, AFD-I22, AFD-I23, AFD-I24)Dropped rules
80d8c194f;但没有提供tests/unit/package/test_package.py的内容,无法证实它也是版本目标。更关键的是,“只靠包的固定版本兜底”被同时用于 Ascend 补丁,而compatibility_and_patches.md:L61-L71明确说仓库未在pyproject.toml中声明 vLLM-Ascend 依赖。", "non_contradictory": "AFD-I22 和 `compatibility_andengine_core.py, but describesnpu/force_load_balance.pyseparately as having no patch-local version guard. The proposed text incorrectly applies the package-pin claim to both patches (compatibility_aAFDTransferContext.states,新规则却无条件要求原样传递(connector_contracts.md:L157-L183)。证据也没有表明 NPU 图缓存必须使用make_ffn_graph_key();它只说明 NPU 的键包含 stage token 计数和 A/F 拓扑(execution_platforms.md:L287-L292)。", "non_contradictory": "现有 AFD-I6 允许图 key 由make_ffn_graph_key()或 stageNeeds human edit:
Notes: