Repository navigation
afd-plugin adapter: route the four unrouted v1 worker files - #269
Conversation
kb init's modules stage (run on 2026-10-01 after the skeleton, PR #268) found the manifest routes 8 of 9 modules; the four files of afd_plugin/v1/worker/ it does not reach were attention_metadata.py, attention_model_runner_v2.py, npu/attention_model_runner_v2.py and ffn_metadata.py. On a manifest-routed repository init never writes routes itself, so it put them on the checklist as review_routes entries. The stage suggested execution-platforms (the owner of most of the module); this follows the manifest's own per-file split instead: the attention files beside attention_model_runner.py under attention-runtime, ffn_metadata.py beside ffn_model_runner.py under ffn-runtime, each with its owner's existing doc. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61942377c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - prefix: afd_plugin/v1/worker/npu/attention_worker.py | ||
| owner: attention-runtime | ||
| doc: repos/afd-plugin/components/attention-runtime/architecture.md | ||
| - prefix: afd_plugin/v1/worker/attention_metadata.py |
There was a problem hiding this comment.
When a PR changes only one of these four newly routed files, RepoAdapter.module_for_path() still returns None because the corresponding attention_runtime and ffn_runtime local_paths lists remain unchanged. _risk_paths() also omits them even though these modules are marked high risk, so a small runtime change can receive a light review and rebase verification assigns it to the generic afd_plugin fallback rather than its actual module. Add all four paths to the matching module definitions as well as review_routes.
Useful? React with 👍 / 👎.
Summary
kb init's modules stage for afd-plugin (2026-10-01, after the skeleton PR #268) found the adapter manifest routes 8 of 9 modules. The four files of
afd_plugin/v1/worker/it does not reach areattention_metadata.py,attention_model_runner_v2.py,npu/attention_model_runner_v2.pyandffn_metadata.py. On a manifest-routed repository kb init never writes routes itself (#266), so it put them on the checklist asreview_routesentries for an adapter PR: this one.The stage suggested
execution-platforms(the owner of most of the module); this follows the manifest's own per-file split instead: the attention files besideattention_model_runner.pyunderattention-runtime,ffn_metadata.pybesideffn_model_runner.pyunderffn-runtime, each with its owner's existing doc.Tests
Routing golden, SDK second-adapter, adapter, pilot and MCP suites pass (86 tests); commit gate approved.
🤖 Generated with Claude Code