Repository navigation
Fix revived non-actionable review findings and stale summaries - #292
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage promotion and the second review round could revive concerns the ensemble reducer had rejected, while verification confirmed true code facts without establishing a current defect. This produced unsupported findings and a summary describing an earlier selection.
Carry rejected candidates and their reasons into promotion, the second round, and verification. Require a current trigger and adverse effect or unmet requirement in the verifier guidance, and drop explicit
not_actionableverdicts. When refinement, disposition filtering, or comment limits change the selected findings, derive the summary from the final set instead of publishing stale reducer prose.Validation: 179 review, ensemble, anchor, planner, SDK, and output-contract tests passed, including regressions for revived harmless configuration facts, hypothetical future validation failures, and stale summaries after findings are added or removed. The complete offline suite also passed (2,432 collected; 19 skipped). SPEC freshness passed.