Repository navigation
Keep feature discovery corrections parallel and preserve canonical entries - #302
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tzhouam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature discovery scanned and reviewed candidates concurrently, but corrected rejected implementation candidates one at a time. Large repositories could therefore spend hours in a serial correction loop after the parallel scan. It also incorrectly promoted every supplemental implementation reference to a mandatory feature entry point, invalidating otherwise complete existing feature knowledge.
Schedule correction extraction and independent review through the same bounded pool. The coordinator saves each extracted draft before submitting its review, retains the three-correction limit, and drains already running calls after a budget stop. Native proofs, prompts, catalog boundaries, policy and checkpoint identity stay compatible.
Supplement, alias, subcapability and shared-component evidence now expands the associated source/document paths while preserving the target's canonical entry points. New feature creation and the all-entry-point citation coverage gate are unchanged.
Validation: 143 focused discovery tests passed; independent reviews ran 140 checkpoint/handoff tests and 161 catalog/coverage/depth tests, finding no actionable issues. New cases verify the shared 13-call ceiling, coordinator-only checkpoint writes, draft reuse, bounded corrections, budget drain, per-candidate failures and canonical entries through alias chains.
git diff --checkpassed.