Repository navigation
Consolidate provisional feature capabilities with counterpart source review - #304
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f083be7763
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def _review_consolidation(self, rows, features, marker): | ||
| payload = {"repository": self.repository, "pin": self.pin, "candidates": rows, | ||
| "baseline": _formal_catalog(self.seeds), | ||
| "provisional_catalog": _consolidation_summaries(self.state, features, self.seeds), |
There was a problem hiding this comment.
Bound the full provisional catalog in each review request
When a repository produces many admitted proposals, every 12-candidate consolidation request includes the entire provisional catalog without the character bound used by _bounded_baseline; the task count is unbounded and each candidate may carry a 2,000-character description plus aliases and evidence. A sufficiently large catalog therefore exceeds the judge's context limit on every batch, after which the ModelUnavailable path records all affected candidates as terminal unknowns, dropping newly discovered features or blocking a seedless run. Partition or deterministically bound the counterpart summaries instead of replaying the complete catalog in every request.
Useful? React with 👍 / 👎.
Feature discovery could admit the UI and backend of one capability as separate new features when the prior boundary review only saw counterpart proposal summaries. This adds a final independent Codex consolidation over the actual provisional catalog, with pinned counterpart and consumer excerpts; original formal IDs, scans, primary reviews and boundary proofs remain intact.
Unpublished previews acquire the new audit through the official entry point without rescanning or resetting repairs. Successful batches resume from their native receipts; rejected or unresolved items remain unknown. Publication and prepared-resume checks bind the provisional catalog, candidate and boundary hashes, actual native instructions, and source excerpts. Compact reports retain the supplemental audit identity, with full evidence outside Git.
Validation: 191 relevant engine, boundary, stage, report, integration, index, depth-handoff and consolidation tests passed; diff check passed. Regressions cover cross-layer capabilities with different aliases, middle consumer wiring, protected original IDs, stable resume identity, budget interruption, shared concurrency 13, and missing/tampered native archives on cached or prepared publication.