Repository navigation
Quarantine contradictory provisional canonical feature claims - #306
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d920ee01c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| canonical = re.search(r"\bcanonical(?:\s+\S+){0,8}\s+(?:capability|feature|boundary|entry|implementation)\b|" | ||
| r"\bthis\s+id\s+(?:is|as|remains)(?:\s+the)?\s+canonical\b", sentence, re.I) | ||
| if exact.search(sentence) and canonical and not re.search( | ||
| r"\b(?:not|never|non)[ -]+(?:the[ ]+)?canonical\b", sentence, re.I): |
There was a problem hiding this comment.
When two distinct candidates receive reasons such as This ID is canonical, while web is a distinct feature and the converse for backend, this treats them as mutually contradictory because it only requires the other ID and any canonical phrase to occur in the same sentence. catalog() then changes both independently accepted features to unknown, dropping legitimate entries. The check needs to establish that the canonical claim actually applies to the referenced candidate rather than relying on sentence co-occurrence.
Useful? React with 👍 / 👎.
Two independently approved new feature candidates can both claim to be canonical for the same capability and explicitly name each other. Catalog rendering now quarantines both proposals as unknown instead of publishing duplicate canonical entries; it retains their original native decisions and receipts. The guard applies only to consolidated provisional additions, preserving existing formal IDs and the original consolidation input set.
A separate renderer marker makes completed unpublished previews rerender through the official entry point without model calls. Published history stays immutable, and prepared publications from an earlier renderer remain blocked until a separate preview is reviewed.
Validation: 202 discovery, boundary, consolidation, stage, report, integration, index and depth-handoff tests passed; diff check passed. Cases include mutual versus one-way or unrelated claims, exact-ID boundaries, negation, new-plus-supplement relations, original IDs, and cached no-model migration.