Repository navigation
Stabilize the objective coordinator routing test cohort - #307
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The objective coordinator routing test intermittently returns
deferredbecause its positive fixture has only 68 holdouts. The real coordinator replenishes this pool below its floor of 80, introduces randomly ordered negative controls, and can select enough of them to make the eight-item experiment underpowered.Prepare a second genuine scenario pool and apply the fixture’s existing positive-only policy before this one test, keeping at least 88 holdouts available. The legacy-forensics prohibition, resume assertions, production statistics, replenishment behavior, and independent negative-control tests remain unchanged.
Validation: autonomous/evolution suites passed 74 cases, with one existing sandbox probe skipped because user namespaces are disabled; the statistics test passed; six fresh-UUID repetitions of the coordinator test passed. Independent review found no issues and separately passed all 37 autonomous tests. The rebased branch contains only the nine-line test change.