Repository navigation
fix(kb): retrieve adjacent pinned guides during depth extraction - #321
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aed86ceaba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if context.index is not None and not guidance: | ||
| # Preserve the already selected local document ranges; a second | ||
| # full-index rerank can replace their commands/criteria. Bind | ||
| # the actual final packet, without changing any saved payload. | ||
| retrieval["docs"] = docs |
There was a problem hiding this comment.
When an indexed lightweight feature has a large explicit or adjacent guide whose relevant section mentions a source symbol but not the source filename or generic facet keywords, _docs() can retain only unrelated earlier slices because it ranks without the symbols that DepthContext.build() derives. build() still finds the symbol-relevant range, but this assignment overwrites it with the first-pass slices; across the four bounded repair rounds, late sections can therefore remain unavailable and a supportable facet may be exhausted as unknown. Preserve the symbol-ranked result or pass the source symbols into the initial selection.
Useful? React with 👍 / 👎.
Source-only discovered features can have useful SKILL, README and reference guides beside their implementation even when the catalog has
docs: []. Depth extraction previously supplied generic owner documents instead, and a second full-index selection could discard local commands and acceptance criteria.Select nearby indexed component documents and relevant source-filename examples within the existing 8 KB document budget, then preserve the final selected packet and its context hash. Stored native payloads, source pin, model roles, acceptance rules and lifetime repair counters remain bound to the original campaign.
Validation: targeted retrieval and interrupted-resume regressions; independent fixed-source smoke checks for DOCX, PPT, trace preprocessing and audit HTML rendering in full-facet and validation-only packets. Full CI runs on this PR head.